fix: pressability measureAsyncOnUI only running on Android cp-7.58.2

[tommasini]

Description

#22323

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Uses measureAsyncOnUI for Android press interactions and wires new Fabric async measure APIs across JS, native (iOS/Android), and tests; updates RN to a Yarn patch.

• Press interactions:
  • Libraries/Pressability/Pressability.js: Use measureAsyncOnUI only on Android; keep measure on other platforms.
• Fabric measurement APIs:
  • JS/TS interfaces: Add measureAsyncOnUI to FabricUIManager (Libraries/ReactNative/FabricUIManager.js) and expose via ReactFabricHostComponent.
  • JS bridge: Implement UIManagerBinding.measureAsyncOnUI to call back into JS.
  • Scheduler/Delegates: Add async measure pathways (Scheduler, SchedulerDelegate, UIManagerDelegate).
• iOS (Fabric):
  • Add RCTMountingManager.measure and route via RCTSurfacePresenter to perform measurement on main thread.
• Android (Fabric):
  • Add FabricUIManager.measureAsync, MountingManager.measure (with bounding box computation), and JNI plumbing (Binding, FabricMountingManager) to call into Java and invoke callbacks.
• Tests and RN DOM shim:
  • jest/setup.js: Mock measureAsyncOnUI.
  • ReactNativeElement: Add measureAsyncOnUI delegating to measure.
• Build config:
  • package.json/yarn.lock: Point react-native@0.76.9 to local Yarn patch.

^{Written by Cursor Bugbot for commit 3df2f0f. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[cursor]

Bug: Android measure: Inconsistent error callbacks

The Android measure method returns early without invoking the callback when the view is not found or when rootView is null. This leaves the JavaScript callback waiting indefinitely, causing potential hangs. The iOS implementation correctly invokes the callback with an empty object in error cases, but Android doesn't match this behavior.

.yarn/patches/react-native-npm-0.76.9-1c25352097.patch#L460-L474

metamask-mobile/.yarn/patches/react-native-npm-0.76.9-1c25352097.patch

Lines 460 to 474 in 9b1b659

	+++ b/ReactCommon/react/renderer/scheduler/SchedulerDelegate.h
	@@ -62,6 +62,10 @@ class SchedulerDelegate {
	bool isJSResponder,
	bool blockNativeResponder) = 0;
	+ virtual void schedulerMeasureAsync(
	+ const ShadowView& shadowView,
	+ const std::function<void(folly::dynamic)>& callback) = 0;
	+
	virtual ~SchedulerDelegate() noexcept = default;
	};
	diff --git a/ReactCommon/react/renderer/uimanager/UIManagerBinding.cpp b/ReactCommon/react/renderer/uimanager/UIManagerBinding.cpp
	index de07a2847b647bacb8130df901aa76818c831154..03eb507bbf62d87f10cf7baa10fd59a5b23987de 100644
	--- a/ReactCommon/react/renderer/uimanager/UIManagerBinding.cpp

 

---

Bug: Cross-Platform Measurement Inconsistency

The Android measure callback invokes with hardcoded 0, 0 as the first two parameters, while the iOS implementation returns frame.origin.x and frame.origin.y. This platform inconsistency means the same measurement API returns different values on Android versus iOS, breaking cross-platform compatibility.

.yarn/patches/react-native-npm-0.76.9-1c25352097.patch#L483-L484

metamask-mobile/.yarn/patches/react-native-npm-0.76.9-1c25352097.patch

Lines 483 to 484 in 9b1b659

	+ runtime,
	+ name,

 

---

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud