Skip to content

Conversation

@kevinbluer
Copy link
Member

@kevinbluer kevinbluer commented Nov 10, 2025

Description

  • Removes the mandatory terms of service modal

Changelog

CHANGELOG entry: null

Related issues

Fixes: PRED-297

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Removes the Predict ToS consent modal and agreement tracking, simplifying buy/sell flows and pruning related controller APIs, types, selectors, and tests.

  • UI (Predict):
    • Remove PredictConsentSheet component and all references from PredictBuyPreview and PredictSellPreview; orders now proceed directly.
    • Keep inline disclaimer with "Learn more" link; no modal gating.
  • Controller:
    • Delete acceptAgreement API from PredictController and all usages.
  • Hooks:
    • Remove usePredictAgreement hook and its tests.
  • Types/Selectors:
    • Simplify PredictAccountMeta to { isOnboarded: boolean }; drop acceptedToS and AcceptAgreementParams.
    • Update selectors/tests to reflect removal of acceptedToS.
  • Tests:
    • Remove consent-related tests and mocks across buy/sell previews and consent sheet; adjust flows to assert direct order placement.

Written by Cursor Bugbot for commit 8c727d0. This will update automatically on new commits. Configure here.

@metamaskbot metamaskbot added the team-predict Predict team label Nov 10, 2025
Copy link
Contributor

@caieu caieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinbluer kevinbluer enabled auto-merge November 10, 2025 22:15
@sonarqubecloud
Copy link

@kevinbluer kevinbluer added this pull request to the merge queue Nov 11, 2025
Merged via the queue into main with commit b10575a Nov 11, 2025
149 of 152 checks passed
@kevinbluer kevinbluer deleted the chore/predict-rm-tos-first-trade branch November 11, 2025 05:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2025
@metamaskbot metamaskbot added the release-7.60.0 Issue or pull request that will be included in release 7.60.0 label Nov 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.60.0 Issue or pull request that will be included in release 7.60.0 size-XL team-predict Predict team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants