-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: remove Tron non tradable assets from token selector #22471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bfullam
merged 5 commits into
swaps-tron-integration
from
swaps-3419-filter-out-non-tradable-assets
Nov 12, 2025
Merged
feat: remove Tron non tradable assets from token selector #22471
bfullam
merged 5 commits into
swaps-tron-integration
from
swaps-3419-filter-out-non-tradable-assets
Nov 12, 2025
+787
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
bfullam
reviewed
Nov 11, 2025
…ut-non-tradable-assets
bfullam
reviewed
Nov 11, 2025
bfullam
approved these changes
Nov 11, 2025
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Description
Tron Snap currently treats 'energy' and 'bandwidth' as assets, which causes them to appear in asset lists, including the Swaps asset pickers. Since these are not tradeable assets, we need to implement filtering on the asset pickers to exclude them from the UI. We ensure that 'energy' and 'bandwidth' are not displayed in asset pickers where tradeable assets are expected.
Changelog
CHANGELOG entry: Remove non-tradable assets from asset picker
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-3419
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Filters Tron resource tokens (Energy, Bandwidth, Max Bandwidth) from bridge token lists and adds comprehensive tests, including non-EVM address normalization and edge cases.
isTradableTokenutility to exclude Tron resource tokens (Energy,Bandwidth,Max Bandwidth) onTrxScope.Mainnet.useTokens):isTradableTokenwhen buildingtokensWithoutBalance,allTokens, andtokensToRender.useTokens.test.tsto cover:formatAddressToAssetIdand error on empty normalization.tokensWithBalance,topTokens, andremainingTokens.isTradableTokenwith Tron and non-Tron scenarios.Written by Cursor Bugbot for commit 38c4cfc. This will update automatically on new commits. Configure here.