Skip to content

Conversation

@abretonc7s
Copy link
Contributor

@abretonc7s abretonc7s commented Nov 12, 2025

Description

Adjusted the funding tooltip copy in the position component to display position-specific information. Previously, both the position card's "Funding Cost" and the market statistics "Funding Rate" used the same generic tooltip explaining funding rates. This change adds a dedicated tooltip for funding payments that clarifies it represents the cumulative amount paid/received since the position opened.

Changes:

  • Added new funding_payments tooltip type
  • Updated position card to use the new tooltip
  • Market statistics continues to use the existing funding_rate tooltip

Changelog

CHANGELOG entry: Updated funding tooltip in position component to show position-specific information

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/TAT-1880

Manual testing steps

Feature: Funding payments tooltip in position component

  Scenario: user views funding tooltip in position card
    Given user has an open perp position
    And the position card displays the "Funding" field with an info icon

    When user taps the info icon next to "Funding" in the position card
    Then the tooltip displays title "Funding payments"
    And the tooltip content reads "This is the amount you've paid in funding fees since the position was opened. Funding is paid or received every hour to keep the perp price close to the actual token price."

  Scenario: user views funding rate tooltip in market statistics
    Given user is viewing market statistics for a perp

    When user taps the info icon next to "Funding rate"
    Then the tooltip displays title "Funding rate"
    And the tooltip content describes the general funding rate concept

Screenshots/Recordings

Before

Position card showed generic funding rate tooltip (same as market statistics)

After

Position card shows position-specific funding payments tooltip with cumulative payment context

funding_fee_funding_rate.mp4

Pre-merge author checklist

  • I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards
  • I've completed the PR template to the best of my ability
  • I've included tests if applicable (N/A - localization change only)
  • I've documented my code using JSDoc format if applicable (N/A)
  • I've applied the right labels on the PR

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed)
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots

Note

Introduces a new funding_payments tooltip and switches the position card’s funding info icon to use it, with corresponding registry and locale updates.

  • Perps Tooltips:
    • Add new content key funding_payments to PerpsTooltipContentKey and register in contentRegistry.
  • Position Card:
    • Change funding info icon handler from funding_rate to funding_payments in PerpsPositionCard.
  • Localization:
    • Add perps.tooltips.funding_payments strings (title and content) in en.json.

Written by Cursor Bugbot for commit 2149df2. This will update automatically on new commits. Configure here.

@abretonc7s abretonc7s requested a review from a team as a code owner November 12, 2025 02:10
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-perps Perps team label Nov 12, 2025
@sonarqubecloud
Copy link

Copy link
Contributor

@michalconsensys michalconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abretonc7s abretonc7s added this pull request to the merge queue Nov 12, 2025
Merged via the queue into main with commit 7864152 Nov 12, 2025
100 checks passed
@abretonc7s abretonc7s deleted the feat/perps/tat-1880-fundingtooltip branch November 12, 2025 10:32
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2025
@metamaskbot metamaskbot added the release-7.60.0 Issue or pull request that will be included in release 7.60.0 label Nov 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.60.0 Issue or pull request that will be included in release 7.60.0 size-XS team-perps Perps team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants