Skip to content

Conversation

@kevinbluer
Copy link
Member

@kevinbluer kevinbluer commented Nov 13, 2025

Description

  • Adds correct empty state when no search results are found

Changelog

CHANGELOG entry: null

Related issues

Fixes: PRED-295

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Simulator Screenshot - iPhone 16 Pro Max - 2025-11-13 at 10 06 02 Simulator Screenshot - iPhone 16 Pro Max - 2025-11-13 at 09 57 57

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds a localized, themed empty state for no search results in Predict market list, updates styles/tests, and adds i18n strings and assets.

  • Predict UI:
    • Search Empty State: When q is present and no results, render themed illustration and message in app/components/UI/Predict/components/MarketListContent/MarketListContent.tsx using useAssetFromTheme, PredictionsLight/Dark SVGs, and strings('predict.search_no_markets_found', { q }).
    • Default Empty State: Replace hardcoded copy with strings('predict.search_empty_state', { category }).
    • Styles: Add emptySearchContainer in MarketListContent.styles.ts.
  • Tests:
    • Update MarketListContent.test.tsx to support q prop, and add test asserting search empty state (icon + localized text) via getPredictMarketListSelector.emptyState().
  • Assets & i18n:
    • Add predictions-no-search-results-light.svg and predictions-no-search-results-dark.svg.
    • Add predict.search_empty_state and predict.search_no_markets_found to locales/languages/en.json.

Written by Cursor Bugbot for commit 2f19186. This will update automatically on new commits. Configure here.

@metamaskbot metamaskbot added the team-predict Predict team label Nov 13, 2025
@kevinbluer kevinbluer enabled auto-merge November 13, 2025 17:00
@sonarqubecloud
Copy link

@kevinbluer kevinbluer added this pull request to the merge queue Nov 13, 2025
Merged via the queue into main with commit e3a5282 Nov 13, 2025
120 of 121 checks passed
@kevinbluer kevinbluer deleted the chore/predict-adds-no-search-visual-state branch November 13, 2025 18:24
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2025
@metamaskbot metamaskbot added the release-7.60.0 Issue or pull request that will be included in release 7.60.0 label Nov 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.60.0 Issue or pull request that will be included in release 7.60.0 size-M team-predict Predict team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants