Skip to content

Conversation

@Montoya
Copy link
Contributor

@Montoya Montoya commented Nov 14, 2025

Correct translation for card onboarding flow in Spanish

Description

A typo and poor translation in the card onboarding flow needed correcting for Spanish

Changelog

CHANGELOG entry: null

Related issues

Fixes: n/a

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Refines Spanish text for MetaMask Card onboarding by correcting the non-cardholder title and description.

Written by Cursor Bugbot for commit 356e6fb. This will update automatically on new commits. Configure here.

Correct translation for card onboarding flow in Spanish
@Montoya Montoya added team-card Card Team size-XS release-7.59.0 Issue or pull request that will be included in release 7.59.0 regression-RC-7.58.2 Regression bug that was found in release candidate (RC) for release 7.58.2 labels Nov 14, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-rewards Rewards team label Nov 14, 2025
@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

The only changed file is locales/languages/es.json, which is a Spanish language translation file. This is a pure localization change that:

  1. Does not affect functionality: Translation files only contain translated strings and do not contain any executable code or logic
  2. Does not impact E2E tests: E2E tests typically use test IDs and selectors that are not language-dependent, and there's no evidence of E2E tests relying on Spanish translations (search found no references to Spanish locale in e2e/ directory)
  3. Low risk: Translation updates cannot break core wallet functionality, network operations, UI logic, or any critical user flows
  4. No code changes: Only JSON translation data was modified

Since this is purely a content/localization change with no functional impact, no E2E tests need to be run. The risk is low and confidence is high (95%) because:

  • The change is confined to translation content only
  • No code logic, components, controllers, or critical paths were modified
  • E2E tests don't validate translated text content
  • The file type and location clearly indicate non-functional changes

View GitHub Actions results

@Montoya Montoya changed the title Update Spanish strings for Card onboarding flow cp-7.58.3 chore: Update Spanish strings for Card onboarding flow cp-7.58.3 Nov 14, 2025
@vpintorico vpintorico enabled auto-merge November 14, 2025 17:31
@sonarqubecloud
Copy link

@vpintorico vpintorico added this pull request to the merge queue Nov 14, 2025
Merged via the queue into main with commit a4bf0dd Nov 14, 2025
99 of 104 checks passed
@vpintorico vpintorico deleted the chore/card-string-es-fix branch November 14, 2025 18:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2025
@metamaskbot metamaskbot added the release-7.61.0 Issue or pull request that will be included in release 7.61.0 label Nov 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

regression-RC-7.58.2 Regression bug that was found in release candidate (RC) for release 7.58.2 release-7.59.0 Issue or pull request that will be included in release 7.59.0 release-7.61.0 Issue or pull request that will be included in release 7.61.0 size-XS team-card Card Team team-rewards Rewards team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants