Skip to content

Conversation

@Battambang
Copy link
Contributor

@Battambang Battambang commented Nov 17, 2025

Description

Updates bitcoin to 1.6.0, which updates from and to fields in the confirmation modal.

Changelog

CHANGELOG entry: Adds from and to to Bitcoin confirmation UI

Related issues

Fixes: MetaMask/metamask-extension#37845

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Updates dependency @metamask/bitcoin-wallet-snap from ^1.5.0 to ^1.6.0.

Written by Cursor Bugbot for commit 9010905. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​bitcoin-wallet-snap@​1.5.0 ⏵ 1.6.01001008398 +1100

View full report

@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeCore, SmokeConfirmationsRedesigned, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeWalletUX, SmokeAssets, SmokeSwaps, SmokeStake, SmokeCard, SmokeNotifications, SmokeRewards, SmokePerps, SmokeRamps, SmokeMultiChainPermissions, SmokeAnalytics, SmokeMultiChainAPI, SmokePredictions
  • Risk Level: high
  • AI Confidence: 60%
click to see 🤖 AI reasoning details

The changes involve package.json (marked as CRITICAL) and yarn.lock, which are fundamental configuration files for the entire project. Without access to the git diff, I cannot determine the exact nature of the changes, but these files typically contain:

  1. Dependency Updates: The package.json file contains 200+ dependencies including:

    • MetaMask core controllers (@metamask/assets-controllers, @metamask/transaction-controller, etc.)
    • React Native framework and related libraries
    • E2E testing frameworks (Detox, Appium, WDIO)
    • Multiple MetaMask Snap packages
    • Multi-chain support packages (Solana, Bitcoin, Tron)
    • Bridge, Swap, Stake, Card, Predictions, and other feature-specific controllers
  2. Impact Assessment:

    • Changes to package.json can affect the entire application
    • Controller updates could impact wallet functionality, network operations, transaction handling
    • React Native version changes could affect UI/UX across the board
    • Testing framework updates could affect E2E test infrastructure
    • The yarn.lock changes confirm that actual dependency resolution has changed
  3. Risk Factors:

    • Cannot determine if this is a minor version bump or major dependency updates
    • Cannot see if critical security patches were applied
    • Cannot assess if new dependencies were added or removed
    • Files in app/core/ import package.json for version information, suggesting runtime dependencies
  4. Conservative Approach:

    • Given the CRITICAL file designation and inability to see specific changes
    • Dependency updates can have cascading effects across features
    • Testing all tags ensures comprehensive coverage of potential impacts
    • This is the safest approach when dealing with fundamental configuration changes

The confidence is 60% because while I'm certain package.json changes warrant extensive testing, I cannot see the actual diff to determine if changes are minor (version bump) or major (controller upgrades, new features).

View GitHub Actions results

@aganglada aganglada changed the title fix: bump bitcoin fix: cp-7.60.0 bump bitcoin Nov 17, 2025
@sonarqubecloud
Copy link

@aganglada aganglada enabled auto-merge November 17, 2025 16:13
@aganglada aganglada added this pull request to the merge queue Nov 17, 2025
Merged via the queue into main with commit 5c22aa6 Nov 17, 2025
110 of 114 checks passed
@aganglada aganglada deleted the chore/bump-bitcoin-1-6-0 branch November 17, 2025 16:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2025
@metamaskbot metamaskbot added the release-7.61.0 Issue or pull request that will be included in release 7.61.0 label Nov 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.61.0 Issue or pull request that will be included in release 7.61.0 size-XS team-network-enablement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Send - Bitcoin - When I perform a Bitcoin Send I can't see the Recipient address in the last confirmation screen, and missleading Account field

4 participants