Skip to content

chore(deps-dev): bump @metamask/object-multiplex from 1.2.0 to 2.1.0 #22851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −13
Open

chore(deps-dev): bump @metamask/object-multiplex from 1.2.0 to 2.1.0 #22851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@
"@metamask/eslint-plugin-design-tokens": "^1.0.0",
"@metamask/foundryup": "1.0.0",
"@metamask/mobile-provider": "^3.0.0",
"@metamask/object-multiplex": "^1.1.0",
"@metamask/object-multiplex": "^2.1.0",
Copy link

@cursor cursor bot Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Dependency Hell: Stream API Incompatibility

Upgrading @metamask/object-multiplex to 2.1.0 introduces a dependency conflict. The project explicitly depends on readable-stream@2.3.7 (line 668), but v2.1.0 requires readable-stream@^3.6.2. These major versions have incompatible stream APIs and behaviors. This could cause runtime failures when streams interact between different parts of the codebase expecting different readable-stream APIs. The project should either update the direct readable-stream dependency to 3.x or add an explicit resolution to ensure version consistency.

Fix in Cursor Fix in Web

"@metamask/providers": "^18.3.1",
"@metamask/test-dapp": "9.5.0",
"@metamask/test-dapp-multichain": "^0.17.1",
Expand Down
13 changes: 1 addition & 12 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8154,17 +8154,6 @@ __metadata:
languageName: node
linkType: hard

"@metamask/object-multiplex@npm:^1.1.0":
version: 1.2.0
resolution: "@metamask/object-multiplex@npm:1.2.0"
dependencies:
end-of-stream: "npm:^1.4.4"
once: "npm:^1.4.0"
readable-stream: "npm:^2.3.3"
checksum: 10/7c622639cc164c3b780294d790311e4bcb327faf14626717728022e95da5834f32fe4e242d8f4e7d9b8c2b83f0c76450922786b2f6ef50e777bfe119b78bdab7
languageName: node
linkType: hard

"@metamask/object-multiplex@npm:^2.0.0, @metamask/object-multiplex@npm:^2.1.0":
version: 2.1.0
resolution: "@metamask/object-multiplex@npm:2.1.0"
Expand Down Expand Up @@ -34388,7 +34377,7 @@ __metadata:
"@metamask/network-controller": "npm:^25.0.0"
"@metamask/network-enablement-controller": "patch:@metamask/network-enablement-controller@npm%3A3.1.0#~/.yarn/patches/@metamask-network-enablement-controller-npm-3.1.0-1c0cfefdc3.patch"
"@metamask/notification-services-controller": "npm:^20.0.0"
"@metamask/object-multiplex": "npm:^1.1.0"
"@metamask/object-multiplex": "npm:^2.1.0"
"@metamask/permission-controller": "npm:^12.1.0"
"@metamask/phishing-controller": "npm:^15.0.0"
"@metamask/post-message-stream": "npm:^10.0.0"
Expand Down
Loading