-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: Add skeleton loading for the Send flow #22853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+409
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
dan437
commented
Nov 18, 2025
app/components/Views/confirmations/components/confirm/confirm-component.tsx
Outdated
Show resolved
Hide resolved
app/components/Views/confirmations/components/confirm/confirm-component.tsx
Outdated
Show resolved
Hide resolved
app/components/Views/confirmations/components/confirm/confirm-component.tsx
Outdated
Show resolved
Hide resolved
OGPoyraz
previously approved these changes
Nov 18, 2025
app/components/Views/confirmations/components/info/transfer/transfer.tsx
Show resolved
Hide resolved
a9bf194 to
e968ae7
Compare
app/components/Views/confirmations/components/confirm/confirm-component.test.tsx
Show resolved
Hide resolved
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com> Update skeleton loading for the Send flow Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com> Have skeleton loading in individual components Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com> Update styles Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com> Update styles Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com> Update styles Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com> Update styles Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com> Update styles Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
e968ae7 to
2f5656e
Compare
Contributor
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsFallback: AI analysis did not complete successfully. Running all tests. |
|
jpuri
approved these changes
Nov 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-7.61.0
Issue or pull request that will be included in release 7.61.0
size-M
team-transactions
Transactions team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Description
Replaces blank page with a loader for the Send flow with skeleton loading
Changelog
CHANGELOG entry: Replaces blank page with a loader for the Send flow with skeleton loading
Related issues
Fixes:
#19676
#22763
#17838
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds a Transfer-specific skeleton loader (including footer skeleton) to the confirmation screen and routes Send flow to use it, plus skeletons across key info rows.
ConfirmationLoader.Transferand rendersTransferInfoSkeletoninconfirm-component.tsx.InfoLoaderto acceptloaderand showsFooterSkeletonwhenloader === 'transfer'.customAmount,predictClaim).FooterSkeletonwith styles (footerSkeletonContainer,footerButtonSkeleton).HeroRowSkeleton,FromToRowSkeleton,NetworkAndOriginRowSkeleton,GasFeesDetailsRowSkeleton,AdvancedDetailsRowSkeletonwith corresponding style additions.react-native-skeleton-placeholderusage with sharedSkeletoncomponent in gas fee row.useSendActions: navigates toRedesignedConfirmationswith{ loader: 'transfer', params: { maxValueMode } }.confirm-component.test.tsxanduseSendActions.test.tsto cover new loaders, SafeArea +ScrollView, defaults, and navigation params.Written by Cursor Bugbot for commit 2f5656e. This will update automatically on new commits. Configure here.