Skip to content

Conversation

@dan437
Copy link
Contributor

@dan437 dan437 commented Nov 18, 2025

Description

Replaces blank page with a loader for the Send flow with skeleton loading

Changelog

CHANGELOG entry: Replaces blank page with a loader for the Send flow with skeleton loading

Related issues

Fixes:
#19676
#22763
#17838

Manual testing steps

  1. Click Send on the main page
  2. Fill in the form, submit it
  3. You will see skeleton loading now

Screenshots/Recordings

Before

image

After

image image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds a Transfer-specific skeleton loader (including footer skeleton) to the confirmation screen and routes Send flow to use it, plus skeletons across key info rows.

  • Confirmations UI
    • Adds ConfirmationLoader.Transfer and renders TransferInfoSkeleton in confirm-component.tsx.
    • Extends InfoLoader to accept loader and shows FooterSkeleton when loader === 'transfer'.
    • Keeps default spinner; retains existing loaders (customAmount, predictClaim).
  • Footer
    • Introduces FooterSkeleton with styles (footerSkeletonContainer, footerButtonSkeleton).
    • Refactors base footer styles for reuse.
  • Transfer Info Skeletons
    • Adds skeleton components for rows: HeroRowSkeleton, FromToRowSkeleton, NetworkAndOriginRowSkeleton, GasFeesDetailsRowSkeleton, AdvancedDetailsRowSkeleton with corresponding style additions.
    • Replaces react-native-skeleton-placeholder usage with shared Skeleton component in gas fee row.
  • Navigation/Send Flow
    • useSendActions: navigates to RedesignedConfirmations with { loader: 'transfer', params: { maxValueMode } }.
  • Tests
    • Updates confirm-component.test.tsx and useSendActions.test.ts to cover new loaders, SafeArea + ScrollView, defaults, and navigation params.

Written by Cursor Bugbot for commit 2f5656e. This will update automatically on new commits. Configure here.

@dan437 dan437 requested a review from a team as a code owner November 18, 2025 10:06
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-transactions Transactions team label Nov 18, 2025
OGPoyraz
OGPoyraz previously approved these changes Nov 18, 2025
@dan437 dan437 force-pushed the confirmations-skeleton-loading branch 2 times, most recently from a9bf194 to e968ae7 Compare November 19, 2025 12:56
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

Update skeleton loading for the Send flow

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

Have skeleton loading in individual components

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

Update styles

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

Update styles

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

Update styles

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

Update styles

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

Update styles

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
@dan437 dan437 force-pushed the confirmations-skeleton-loading branch from e968ae7 to 2f5656e Compare November 19, 2025 16:06
@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeCore, SmokeConfirmationsRedesigned, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeWalletUX, SmokeAssets, SmokeSwaps, SmokeStake, SmokeCard, SmokeNotifications, SmokeRewards, SmokePerps, SmokeRamps, SmokeMultiChainPermissions, SmokeAnalytics, SmokeMultiChainAPI, SmokePredictions
  • Risk Level: high
  • AI Confidence: %
click to see 🤖 AI reasoning details

Fallback: AI analysis did not complete successfully. Running all tests.

View GitHub Actions results

@dan437 dan437 enabled auto-merge November 19, 2025 16:14
@sonarqubecloud
Copy link

@dan437 dan437 added this pull request to the merge queue Nov 19, 2025
Merged via the queue into main with commit cfa5ba0 Nov 19, 2025
152 of 154 checks passed
@dan437 dan437 deleted the confirmations-skeleton-loading branch November 19, 2025 18:11
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2025
@metamaskbot metamaskbot added the release-7.61.0 Issue or pull request that will be included in release 7.61.0 label Nov 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.61.0 Issue or pull request that will be included in release 7.61.0 size-M team-transactions Transactions team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants