Skip to content

Conversation

@zone-live
Copy link
Contributor

@zone-live zone-live commented Nov 18, 2025

Description

Fixes the Tron token logo in the tokens list, it was missing because TokenIcon looks up images by ticker (TRX), but image-icons only mapped the Tron icon under TRON. So we had to wire the Tron PNG to TRX (and the new tron-logo.png) so the token list can render the correct icon.

Screenshot 2025-11-18 at 11 00 11

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Updates Tron image to tron-logo.png and maps TRX and sTRX tickers to use the Tron icon.

  • Icons:
    • Tron (app/images/image-icons.js):
      • Switch asset to tron-logo.png.
      • Add mappings TRX and sTRX to TRON so they resolve to the Tron icon.

Written by Cursor Bugbot for commit c40e334. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

aganglada
aganglada previously approved these changes Nov 18, 2025
@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeNetworkExpansion, SmokeAssets, SmokeWalletPlatform
  • Risk Level: medium
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

The changes update image assets for TRON network support, specifically:

  1. Renamed TRON logo import from 'tron.png' to 'tron-logo.png'
  2. Added icon mappings for TRX (native TRON token) and sTRX (staked TRX) tokens

These image icons are used extensively across the app in 18+ components including:

  • Network selector (network switching UI)
  • Asset display and management
  • Token swaps
  • Staking components
  • Confirmations
  • Account management

The changes are feature-flagged under ONLY_INCLUDE_IF(tron), indicating they relate to Tron network support.

Risk Assessment: Medium

  • These are visual asset changes, not core logic changes
  • However, incorrect icon mappings could break UI rendering in multiple places
  • The changes affect user-facing components across network selection and asset display

Recommended Test Tags:

  1. SmokeNetworkExpansion - Tests new network additions and configurations, TRON network support
  2. SmokeAssets - Tests asset display and management, ensuring TRX and sTRX tokens display correctly
  3. SmokeWalletPlatform - Tests core wallet functionality including network switching, which uses these icons

These tests will verify that the icon changes don't break existing functionality and that TRON-related UI elements display correctly.

View GitHub Actions results

@sonarqubecloud
Copy link

@zone-live zone-live added this pull request to the merge queue Nov 19, 2025
Merged via the queue into main with commit e420b1e Nov 19, 2025
138 of 139 checks passed
@zone-live zone-live deleted the NWNT-fix-tron-logo branch November 19, 2025 17:04
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2025
@metamaskbot metamaskbot added the release-7.61.0 Issue or pull request that will be included in release 7.61.0 label Nov 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.61.0 Issue or pull request that will be included in release 7.61.0 size-XS team-new-networks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants