-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(perps): add recent activity section to market details view #22865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(perps): add recent activity section to market details view #22865
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
abretonc7s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but is there a way we can prevent the high duplication of code? currently sonarcloud seems to fail at 12.6% of duplicated code
app/components/UI/Perps/components/PerpsMarketTradesList/PerpsMarketTradesList.tsx
Outdated
Show resolved
Hide resolved
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsThis PR adds a new "Recent Trades" component to the Perps market details view. The changes are:
Impact Assessment:
Risk Level: Low because:
Test Selection: SmokePerps is sufficient because:
|
|



Description
This PR adds a "Recent activity" section to the Perps Market Details view, displaying the 3 most recent trades for the selected market.
Changelog
CHANGELOG entry: Added recent activity section to Perps market details screen showing the 3 most recent trades
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/TAT-1968?atlOrigin=eyJpIjoiODNjZmM2NDUwZGM2NDVmMmE1NmM5MGI5NDJmODBkMGIiLCJwIjoiaiJ9
Manual testing steps
Screenshots/Recordings
Before
After
Simulator.Screen.Recording.-.iPhone.16e.-.2025-11-18.at.13.02.52.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds a "Recent activity" section to Perps Market Details showing up to 3 latest trades with navigation to Activity and trade detail, plus supporting constants, i18n, and tests.
PerpsMarketTradesListintoPerpsMarketDetailsView, positioned above the risk disclaimer; movesPerpsNavigationCardbelow the disclaimer.components/PerpsMarketTradesListusePerpsOrderFills, transforms to transactions, filters bysymbol, sorts bytimestamp, and limits toPERPS_CONSTANTS.RECENT_ACTIVITY_LIMIT.Routes.PERPS.ACTIVITY), shows skeleton while loading, empty state when no trades, and navigates toRoutes.PERPS.POSITION_TRANSACTIONon item press.PERPS_CONSTANTS.RECENT_ACTIVITY_LIMIT = 3inperpsConfig.perps.market.recent_tradesandperps.market.no_tradesstrings.PerpsMarketTradesList.test.tsx.Written by Cursor Bugbot for commit 2db4a4a. This will update automatically on new commits. Configure here.