Skip to content

Conversation

@salimtb
Copy link
Contributor

@salimtb salimtb commented Nov 18, 2025

Description

add browser button

Changelog

CHANGELOG entry: add browser button

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Screen.Recording.2025-11-18.at.14.09.41.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds a browser button that displays the open tab count and refactors search bar layout/padding across Trending and Explore screens, with tests for states and navigation.

  • TrendingView UI
    • Replaces header controls with a row containing ExploreSearchBar and a bordered browser button.
    • Browser button now shows browser.tabs.length as a ButtonLink label; falls back to Add icon when zero.
    • Integrates theme colors for border and updates padding (px-4/pb-3).
  • ExploreSearchBar
    • Removes outer padding wrapper; exposes just the row layout and content.
    • Keeps interactive mode clear/cancel; cancel rendered alongside input when focused.
  • ExploreSearchScreen
    • Wraps ExploreSearchBar in a padded container (px-4 pb-3).
  • Tests (TrendingView.test.tsx)
    • Adds cases for browser button states (0/1/many tabs) and navigation to TrendingBrowser.
    • Verifies presence of search bar button and header title.

Written by Cursor Bugbot for commit 72174b6. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb changed the title Feat/brwoser button feat: brwoser button Nov 18, 2025
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.20%. Comparing base (95f744f) to head (9d81090).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
app/components/Views/TrendingView/TrendingView.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22871      +/-   ##
==========================================
- Coverage   78.22%   78.20%   -0.02%     
==========================================
  Files        3888     3893       +5     
  Lines      100184   100262      +78     
  Branches    19752    19782      +30     
==========================================
+ Hits        78364    78405      +41     
- Misses      16444    16457      +13     
- Partials     5376     5400      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

>
{browserTabsCount > 0 ? (
<ButtonLink
onPress={handleBrowserPress}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this one is pressed I believe we should navigate to the list of tabs instead of creating a new tab. WDYT? Its what phantom does and from my POV what makes more sense?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the browser team will handle this part , i'm just redirecting to the existing browser behavior

@salimtb salimtb marked this pull request as ready for review November 19, 2025 09:56
@salimtb salimtb enabled auto-merge November 19, 2025 10:12
@salimtb salimtb disabled auto-merge November 19, 2025 12:44
@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeCore, SmokeConfirmationsRedesigned, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeWalletUX, SmokeAssets, SmokeSwaps, SmokeStake, SmokeCard, SmokeNotifications, SmokeRewards, SmokePerps, SmokeRamps, SmokeMultiChainPermissions, SmokeAnalytics, SmokeMultiChainAPI, SmokePredictions
  • Risk Level: high
  • AI Confidence: %
click to see 🤖 AI reasoning details

Fallback: AI analysis did not complete successfully. Running all tests.

View GitHub Actions results

@salimtb salimtb enabled auto-merge November 19, 2025 14:06
@sonarqubecloud
Copy link

@salimtb salimtb added this pull request to the merge queue Nov 19, 2025
Merged via the queue into main with commit 89e2ce8 Nov 19, 2025
152 of 154 checks passed
@salimtb salimtb deleted the feat/brwoser-button branch November 19, 2025 15:03
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2025
@metamaskbot metamaskbot added the release-7.61.0 Issue or pull request that will be included in release 7.61.0 label Nov 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.61.0 Issue or pull request that will be included in release 7.61.0 size-M team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants