-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: brwoser button #22871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: brwoser button #22871
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22871 +/- ##
==========================================
- Coverage 78.22% 78.20% -0.02%
==========================================
Files 3888 3893 +5
Lines 100184 100262 +78
Branches 19752 19782 +30
==========================================
+ Hits 78364 78405 +41
- Misses 16444 16457 +13
- Partials 5376 5400 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| > | ||
| {browserTabsCount > 0 ? ( | ||
| <ButtonLink | ||
| onPress={handleBrowserPress} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this one is pressed I believe we should navigate to the list of tabs instead of creating a new tab. WDYT? Its what phantom does and from my POV what makes more sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think the browser team will handle this part , i'm just redirecting to the existing browser behavior
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsFallback: AI analysis did not complete successfully. Running all tests. |
|



Description
add browser button
Changelog
CHANGELOG entry: add browser button
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2025-11-18.at.14.09.41.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds a browser button that displays the open tab count and refactors search bar layout/padding across Trending and Explore screens, with tests for states and navigation.
ExploreSearchBarand a bordered browser button.browser.tabs.lengthas aButtonLinklabel; falls back toAddicon when zero.px-4/pb-3).ExploreSearchBarin a padded container (px-4 pb-3).TrendingView.test.tsx)TrendingBrowser.Written by Cursor Bugbot for commit 72174b6. This will update automatically on new commits. Configure here.