fix(snaps): Refactor SnapBridge to use SelectedNetworkController

[GuillaumeRx]

Description

This PR refactors the SnapBridge to use SelectedNetworkController to create a provider proxy. It also removes a lot of unnecessary logic. This fixes an issue where the snap couldn't switch the network.

Changelog

CHANGELOG entry: Fix snap wallet_switchEthereumChain

Related issues

Fixes: #22419

Manual testing steps

1. Set the selected network to any other network than ethereum mainnet (like polygon, base,...)
2. Go to the send flow
3. Expect a valid ENS name to be resolved when trying to send ETH on mainnet

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Refactors SnapBridge to source provider/block tracker from SelectedNetworkController, streamlines the JSON-RPC middleware stack and stream wiring, and types snapId as SnapId in init.

• Snaps:
  • SnapBridge refactor:
    • Use SelectedNetworkController.getProviderAndBlockTracker(snapId) and add createSelectedNetworkMiddleware.
    • Rebuild JSON-RPC engine: origin middleware → selected network → filter/subscription polyfills → preinstalled snaps middleware (when applicable) → permission middleware → snaps method middleware → user RPC middleware (with #getProviderState) → forward via providerAsMiddleware(proxy.provider).
    • Replace custom multiplexing with setupMultiplex and pump; add concise logging; adopt strong typings (SnapId, JsonRpcMiddleware, InternalAccount); remove legacy proxy/network-version logic.
• Engine:
  • In controllers/snaps/execution-service-init.ts, pass snapId as SnapId when creating SnapBridge.

^{Written by Cursor Bugbot for commit 78ef601. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeAccounts, SmokeCore, SmokeConfirmationsRedesigned, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeWalletUX, SmokeAssets, SmokeSwaps, SmokeStake, SmokeCard, SmokeNotifications, SmokeRewards, SmokePerps, SmokeRamps, SmokeMultiChainPermissions, SmokeAnalytics, SmokeMultiChainAPI, SmokePredictions
• Risk Level: high
• AI Confidence: %

click to see 🤖 AI reasoning details

Fallback: AI analysis did not complete successfully. Running all tests.

View GitHub Actions results

[sonarqubecloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud