feat: price API v3 upgrade

[bergarces]

Description

Upgrade assets-controllers to start using Price API v3 spot-prices endpoint.

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-1575

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Upgrades assets-controllers to a preview build and updates code/tests to use TokenRatesController.updateExchangeRates, while narrowing the TokenRatesController messenger scope.

• Core/Dependencies:
  • Upgrade @metamask/assets-controllers to preview version 89.0.1-preview-f83c2058 via npm alias in package.json and lockfile.
  • Token Rates messenger: restrict delegated actions to TokensController:getState, NetworkController:getState and events to TokensController:stateChange, NetworkController:stateChange in app/core/Engine/messengers/token-rates-controller-messenger.ts.
• Token Rates API Migration:
  • Replace TokenRatesController.updateExchangeRatesByChainId with TokenRatesController.updateExchangeRates in tokenRefreshUtils.ts and related tests (Tokens, refreshEvmTokens, refreshTokens, tokenRefreshUtils, OnboardingSuccess).

^{Written by Cursor Bugbot for commit fd5a5c1. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[cursor]

Bug: Test Mocks Out of Sync

The mock setup still defines updateExchangeRatesByChainId but the test expectations were changed to call updateExchangeRates. This mismatch causes tests to fail because the mock method name doesn't match what the implementation calls.

app/components/UI/Tokens/util/refreshEvmTokens.test.ts#L20-L21

metamask-mobile/app/components/UI/Tokens/util/refreshEvmTokens.test.ts

Lines 20 to 21 in 7641d44

	TokenRatesController: {
	updateExchangeRatesByChainId: jest.fn(),

 

---

Bug: Mock method mismatch breaks tests.

The mock setup still defines updateExchangeRatesByChainId but the test expectations were changed to call updateExchangeRates. This mismatch causes tests to fail because the mock method name doesn't match what the implementation calls.

app/components/UI/Tokens/util/refreshTokens.test.ts#L20-L21

metamask-mobile/app/components/UI/Tokens/util/refreshTokens.test.ts

Lines 20 to 21 in 7641d44

	TokenRatesController: {
	updateExchangeRatesByChainId: jest.fn(),

 

---

Bug: Mock method mismatch breaks tests.

The mock setup still defines updateExchangeRatesByChainId but the test expectations were changed to call updateExchangeRates. This mismatch causes tests to fail because the mock method name doesn't match what the implementation calls.

app/components/UI/Tokens/util/tokenRefreshUtils.test.ts#L20-L21

metamask-mobile/app/components/UI/Tokens/util/tokenRefreshUtils.test.ts

Lines 20 to 21 in 7641d44

	TokenRatesController: {
	updateExchangeRatesByChainId: jest.fn(() => Promise.resolve()),

 

---

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeAssets, SmokeWalletPlatform, SmokeCore, SmokeWalletUX
• Risk Level: high
• AI Confidence: 85%

click to see 🤖 AI reasoning details

This PR involves significant changes to core wallet functionality around token rates and asset controllers:

1. Critical Engine Changes: Modified token-rates-controller-messenger.ts (a critical Engine file) by removing AccountsController delegations. This simplifies the messenger but changes how the TokenRatesController interacts with the system.

2. Preview Package Dependency: Upgraded @metamask/assets-controllers to a preview version, which typically contains new features or breaking changes that need thorough testing.

3. API Rename: Changed updateExchangeRatesByChainId to updateExchangeRates across the codebase, suggesting a breaking change in the assets-controllers package.

4. Wide Impact: Token rates affect multiple critical user flows:

   • Asset display and balances (SmokeAssets)
   • Token lists and portfolio views (SmokeWalletPlatform)
   • Onboarding success flows (SmokeWalletUX)
   • Core wallet infrastructure (SmokeCore)

Selected Tags:

• SmokeAssets: Primary impact on asset management, token display, and pricing
• SmokeWalletPlatform: Affects core wallet functionality and token display
• SmokeCore: Engine messenger changes affect core infrastructure
• SmokeWalletUX: Impacts user-facing elements like onboarding and token lists

Risk Level: HIGH because:

• Changes to Engine core infrastructure (critical)
• Preview package dependency (unstable)
• Breaking API changes in a widely-used controller
• Affects token pricing across the entire application

Confidence: 85% - I've thoroughly investigated the changes and their impact through code analysis. The changes are clearly related to asset management and token rates, but the preview package nature adds some uncertainty about what else might be affected.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud