Skip to content

Conversation

@matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Nov 19, 2025

Description

Show an alert if doing a Perps or Predict deposit and there is an existing submitted transaction on the same chain and account.

Changelog

CHANGELOG entry: null

Related issues

Fixes: #22762

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Alerts now trigger for Perps/Predict deposits when an existing transaction is in submitted status on the same chain/account; tests updated/added.

  • Alerts:
    • Update useSignedOrSubmittedAlert to include TransactionStatus.submitted as a blocking status when the current transaction is a Pay type (perpsDeposit, predictDeposit).
  • Tests:
    • Add cases verifying alerts show when an existing transaction is submitted and current type is any in PAY_TYPES.
    • Ensure existing behavior for signed/approved, chain/account checks, and Pay-type messaging remains validated.

Written by Cursor Bugbot for commit 968d285. This will update automatically on new commits. Configure here.

@matthewwalsh0 matthewwalsh0 added team-confirmations Push issues to confirmations team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Nov 19, 2025
@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review November 19, 2025 00:18
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner November 19, 2025 00:18
@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeCore, SmokeConfirmationsRedesigned, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeWalletUX, SmokeAssets, SmokeSwaps, SmokeStake, SmokeCard, SmokeNotifications, SmokeRewards, SmokePerps, SmokeRamps, SmokeMultiChainPermissions, SmokeAnalytics, SmokeMultiChainAPI, SmokePredictions
  • Risk Level: high
  • AI Confidence: %
click to see 🤖 AI reasoning details

Fallback: AI analysis did not complete successfully. Running all tests.

View GitHub Actions results

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.22%. Comparing base (95f744f) to head (968d285).
⚠️ Report is 31 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #22904    +/-   ##
========================================
  Coverage   78.22%   78.22%            
========================================
  Files        3888     3900    +12     
  Lines      100184   100486   +302     
  Branches    19752    19823    +71     
========================================
+ Hits        78364    78608   +244     
- Misses      16444    16466    +22     
- Partials     5376     5412    +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Nov 19, 2025
Merged via the queue into main with commit f01fb75 Nov 19, 2025
111 checks passed
@matthewwalsh0 matthewwalsh0 deleted the fix/mm-pay-existing-transaction-alert branch November 19, 2025 11:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2025
@metamaskbot metamaskbot added the release-7.61.0 Issue or pull request that will be included in release 7.61.0 label Nov 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.61.0 Issue or pull request that will be included in release 7.61.0 size-S team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Predict: deposit fails with MUSD on Ethreum

5 participants