chore(runway): cherry-pick fix: cp-7.60.0 login screen design fixes #22907
+480
−589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2781) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Login screen design fixes: * Replace metamask wordmark animation with static logo. * Change background color to same as in live app * resolve spacing issue in b/w login option switch and unlock button. Jira: https://consensyssoftware.atlassian.net/browse/SL-326, https://consensyssoftware.atlassian.net/browse/SL-323 BugFix: #22770, #22846 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: Login screen design fixes: * #22770 * #22846 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** https://github.com/user-attachments/assets/485fd6cc-40bd-4ade-a040-409d7168b566 <!-- [screenshots/recordings] --> ### **After** https://github.com/user-attachments/assets/92b33de7-466e-48cd-8701-44ce6caec6f9 https://github.com/user-attachments/assets/13372206-c9de-47ca-a22a-d686b55e494b <img width="304" height="637" alt="Screenshot 2025-11-17 at 5 25 08 PM" src="https://github.com/user-attachments/assets/b0cd96fb-a804-496f-a34d-a9d1e17e8ec8" /> <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Replaces onboarding wordmark animation with a static MetaMask logo, starts fox animation on mount, simplifies background handling, and adjusts spacing/layout with corresponding test updates. > > - **Login UI (`app/components/Views/Login`)** > - Replace `OnboardingAnimation` with static MetaMask wordmark image (`METAMASK_NAME`). > - Start `FoxAnimation` on mount (`setStartFoxAnimation('Start')`). > - Remove theme-based SafeAreaView background override; rely on default theme colors. > - Layout tweaks: top padding, align content to `flex-start`, add margins for logo/field, add `unlockButton` top margin. > - Simplify text field styling (remove `textField` background override) and keep error/help/biometry flows intact. > - **Styles (`styles.ts`)** > - Add `metamaskName` style; adjust `container`, `field`, and CTA spacing; remove unused `ctaWrapper*` and theme-dependent `textField` color. > - **Tests** > - Update snapshots to reflect new layout/logo and removed background override. > - Remove style-specific tests; add checks for static logo presence and 100ms seedless-password check timing. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit d0fa9ba. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsFallback: AI analysis did not complete successfully. Running all tests. |
|
joaoloureirop
approved these changes
Nov 19, 2025
metamaskbot
added
the
release-7.60.0
Collaborator
|
No release label on PR. Adding release label release-7.60.0 on PR, as PR was cherry-picked in branch 7.60.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Login screen design fixes:
Jira: https://consensyssoftware.atlassian.net/browse/SL-326,
https://consensyssoftware.atlassian.net/browse/SL-323
BugFix: #22770,
#22846
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Login screen design fixes:
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2025-11-17.at.5.45.50.PM.mov
After
Screen.Recording.2025-11-17.at.4.41.45.PM.mov
Screen.Recording.2025-11-17.at.4.42.54.PM.mov
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Replaces the onboarding wordmark animation with a static MetaMask logo, triggers the fox animation directly, and updates Login layout/spacing and tests.
OnboardingAnimationwith staticImageusingMETAMASK_NAMEinapp/components/Views/Login/index.tsx.setStartFoxAnimation('Start')after 100ms (remove onboarding animation trigger).SafeAreaViewstyling (remove theme-based background override).styles.ts: top padding, wordmark sizing/margins (styles.metamaskName), container alignment toflex-start, input section margins, and unlock button margin.Written by Cursor Bugbot for commit 01a8f0c. This will update automatically on new commits. Configure here.
07d0cec