Skip to content

Conversation

@grvgoel81
Copy link
Contributor

@grvgoel81 grvgoel81 commented Nov 19, 2025

Description

Changelog

CHANGELOG entry: null

Related issues

Fixes:

  • Fix: add timeout to resolve animation mount issue

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

onboard

After

Screen.Recording.2025-11-19.at.3.06.41.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Delays onboarding animation start by 100ms and clears the timeout on unmount to prevent mount-related issues.

  • Onboarding (app/components/Views/Onboarding/index.js):
    • Delay starting startOnboardingAnimation via setTimeout(…, 100) after interactions, storing the id in animationTimeoutId.
    • Clear the pending timeout in componentWillUnmount to avoid running after unmount.

Written by Cursor Bugbot for commit 81b1573. Configure here.

@grvgoel81 grvgoel81 self-assigned this Nov 19, 2025
@grvgoel81 grvgoel81 requested a review from a team as a code owner November 19, 2025 08:09
@grvgoel81 grvgoel81 added the team-web3auth Web3Auth team label Nov 19, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@LeVinhGithub LeVinhGithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm QA

@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeCore, SmokeConfirmationsRedesigned, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeWalletUX, SmokeAssets, SmokeSwaps, SmokeStake, SmokeCard, SmokeNotifications, SmokeRewards, SmokePerps, SmokeRamps, SmokeMultiChainPermissions, SmokeAnalytics, SmokeMultiChainAPI, SmokePredictions
  • Risk Level: high
  • AI Confidence: %
click to see 🤖 AI reasoning details

Fallback: AI analysis did not complete successfully. Running all tests.

View GitHub Actions results

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants