fix: hard code remove GNS feature flag

[vinnyhoward]

Description

Hardcode isRemoveGlobalNetworkSelectorEnabled feature flag

Changelog

CHANGELOG entry:null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

~

Before

~

After

~

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Hardcodes isRemoveGlobalNetworkSelectorEnabled to always return true, removing the environment flag check.

^{Written by Cursor Bugbot for commit 229cac5. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeWalletPlatform, SmokeNetworkAbstractions, SmokeCore, SmokeWalletUX, SmokeAssets, SmokeConfirmationsRedesigned, SmokeAccounts
• Risk Level: high
• AI Confidence: 90%

click to see 🤖 AI reasoning details

Change Analysis

What Changed

The change permanently enables the "Remove Global Network Selector" feature by changing:

// Before:
export const isRemoveGlobalNetworkSelectorEnabled = () =>
  process.env.MM_REMOVE_GLOBAL_NETWORK_SELECTOR === 'true';

// After:
export const isRemoveGlobalNetworkSelectorEnabled = () => true;

This is a feature flag removal that makes a significant UI/UX change permanent.

Impact Assessment

High Risk Classification - This is a critical change because:

1. Widespread Usage: The function is used in 100+ locations across the codebase (confirmed via grep)

2. Core UI Components: Affects critical user-facing flows including:

   • ActivityView: Network filtering UI, layout, and button styling
   • SwitchChainApproval: Network selection behavior during chain switching
   • SendFlow (AddressList, AddressElement): Contact filtering by network, address book display with network badges
   • ContactForm: Network selection in contact management
   • TransactionsView/UnifiedTransactionsView: Transaction filtering and display
   • NetworkSettings: Network management interface

3. Behavioral Changes:

   • Global to filtered network view: Changes from showing all networks to a filtered network-specific view
   • Contact/Address Book behavior: Changes from showing only current-chain contacts to showing all contacts across chains
   • UI Layout: Affects button styles, borders, padding, and overall layout in multiple screens
   • Network switching: Modifies how network selection is handled during approval flows

4. Multi-Chain Impact: Affects how users interact with networks, accounts, and assets across different chains

Test Tag Selection Rationale

SmokeWalletPlatform (Critical):

• Core wallet functionality affected: network switching, account display
• Central to how the wallet operates with multiple networks

SmokeNetworkAbstractions (Critical):

• Directly impacts network layer and multi-chain functionality
• Changes how networks are displayed and filtered throughout the app

SmokeCore (Critical):

• Core app navigation and state management affected
• ActivityView, browser, and fundamental wallet flows impacted

SmokeWalletUX (Critical):

• Major UX changes in network selector, settings, notifications
• Layout and styling changes across multiple screens

SmokeAssets (Important):

• Asset display affected by network filtering changes
• Transaction views and asset management impacted

SmokeConfirmationsRedesigned (Important):

• Send flow confirmations affected (AddressList, AddressElement)
• Approval flows (SwitchChainApproval) modified
• Transaction confirmation UX changes

SmokeAccounts (Important):

• Account management affected through activity views
• Multi-account display with network context changes

Why Not All Tags?

While this is a significant change, certain tags are not relevant:

• Trade/Swaps/Stake/Card/Ramps: No direct impact on these specialized features
• Perps/Predictions: Feature-specific, not affected by network selector changes
• Notifications/Rewards: Not directly impacted by this UI change
• MultiChainPermissions/API: Permission system not affected, only UI changes

Confidence: 90%

High confidence because:

• Clear, well-defined change (feature flag removal)
• Used grep to confirm 100+ usage locations
• Read multiple key files to understand behavioral impacts
• Comprehensive test coverage exists (seen in test files)
• Change is straightforward but has wide-ranging UI/UX implications

The 10% uncertainty is due to potential edge cases or indirect effects in components not directly examined, but the core impact is well understood.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Cal-L]

LGTM

[sethkfman]

LGTM