-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix: start animate when rive onPlay ( ready ) cp-7.60.0 #22982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22982 +/- ##
==========================================
- Coverage 78.28% 78.27% -0.02%
==========================================
Files 3901 3901
Lines 100591 100593 +2
Branches 19861 19861
==========================================
- Hits 78749 78738 -11
- Misses 16432 16443 +11
- Partials 5410 5412 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
grvgoel81
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsFallback: AI analysis did not complete successfully. Running all tests. |
|



Description
In some device on edge cases, sometime the MetaMask riv logo does not appear during the onboarding screen animation.
This is due to race conditions between state triggers and the rive onPlay state.
This PR wait for onPlay state before fire the inputState
Changelog
CHANGELOG entry: null
Related issues
Fixes:
#23048
Manual testing steps
Screenshots/Recordings
Before
IMG_0012.MOV
After
IMG_0014.MOV
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Delay animation triggers until Rive reports onPlay, fixing race conditions that caused onboarding/fox animations to not start.
FoxAnimation: addisPlayingstate andonPlayhandler; triggerfireState('FoxRaiseUp', ...)only after play starts; removeautoplayusage.OnboardingAnimation: gatestartRiveAnimationonisPlaying; addonPlayto set ready state; removeautoplayusage.app/__mocks__/rive-react-native.tsxto acceptonPlayand invoke it on mount for tests.Written by Cursor Bugbot for commit b36851c. This will update automatically on new commits. Configure here.