fix(perps): add missing returnOnEquity calculation in HyperLiquidSubscriptionService cp-7.60.0

[michalconsensys]

Description

This PR fixes a missing returnOnEquity calculation in the HyperLiquidSubscriptionService.aggregateAccountStates() method.

Changelog

CHANGELOG entry: Fixed a bug where the PnL % would not show

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/TAT-2086

Manual testing steps

Feature: Return on Equity calculation in Perps account aggregation

  Scenario: user views account state with open HIP3 positions
    Given user has open perpetual positions with unrealized PnL
    
    Then the returnOnEquity field should be correctly calculated as (unrealizedPnl / marginUsed) * 100
    And the value should be formatted to one decimal place

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Computes returnOnEquity in HyperLiquidSubscriptionService.aggregateAccountStates and adds unit tests covering multiple scenarios and rounding.

• Service:
  • Compute returnOnEquity in HyperLiquidSubscriptionService.aggregateAccountStates as ((totalUnrealizedPnl / totalMarginUsed) * 100).toFixed(1) and include it in the aggregated AccountState.
• Tests:
  • Add ROE test suite in HyperLiquidSubscriptionService.test.ts validating positive, negative, zero-margin, mixed PnL, large gains, and one-decimal rounding; mock adapter accordingly.

^{Written by Cursor Bugbot for commit 316fc46. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeAccounts, SmokeCore, SmokeConfirmationsRedesigned, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeWalletUX, SmokeAssets, SmokeSwaps, SmokeStake, SmokeCard, SmokeNotifications, SmokeRewards, SmokePerps, SmokeRamps, SmokeMultiChainPermissions, SmokeAnalytics, SmokeMultiChainAPI, SmokePredictions
• Risk Level: high
• AI Confidence: %

click to see 🤖 AI reasoning details

Fallback: AI analysis did not complete successfully. Running all tests.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
3 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud