-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: cp-7.60.0 gas station support for metamask pay deposits #23033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
daf60c6 to
5a0d198
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsThis PR introduces changes to the transaction-pay functionality with the following impacts:
Selected Tags Rationale:
The combination of Engine changes, major dependency updates, and modifications to transaction confirmation logic presents significant risk to core wallet operations. |
|
tommasini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey team, can we have approve that the miss aligned peer dependencies are not actually blockers?
- assets-controllers needs to be at v91 currently at 89
- bridge-controller needs to be at v63 currently at 61
- gas fee controller, but that is owned by confirmations team right?
- Network-controller needs to be at v26
tommasini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed with @matthewwalsh0 that peer deps are safe. LGTM!



Description
Support EIP-7702 gas station when depositing with MetaMask Pay.
Changelog
CHANGELOG entry: null
Related issues
Fixes: #6150
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds gas fee token awareness to insufficient balance alerts, simplifies available token selection logic, delegates getGasFeeTokens, and upgrades transaction-pay-controller to v10.
fees.isSourceGasFeeTokenin fee/amount calculations and source network checks withinuseInsufficientPayTokenBalanceAlert.transaction-pay):getAvailableTokens: remove "no native gas" disablement and related i18n; return tokens based on balance/selection/required status only.TransactionController:getGasFeeTokensto the Transaction Pay controller messenger.@metamask/transaction-pay-controllerto^10.0.0(lockfile updated).Written by Cursor Bugbot for commit 5a0d198. This will update automatically on new commits. Configure here.