Skip to content

Conversation

@runway-github
Copy link
Contributor

@runway-github runway-github bot commented Nov 20, 2025

Description

Update controller versions for @metamask/transaction-controller and
@metamask/transaction-pay-controller.

Changelog

CHANGELOG entry: null

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Upgrade @metamask/transaction-controller (61.3.0 → 62.0.0) and @metamask/transaction-pay-controller (7.x → 9.x), updating patches and aligning peer deps; refresh yarn.lock accordingly.

  • Dependencies:
    • Upgrade @metamask/transaction-controller to 62.0.0 (patched reference updated in resolutions and dependencies).
    • Upgrade @metamask/transaction-pay-controller to ^9.0.0.
    • Align related peer deps in lockfile:
      • @metamask/controller-utils^11.16.0.
      • Peers: accounts-controller ^35, gas-fee-controller ^26, network-controller ^26.
      • Transaction Pay peers: assets-controllers ^90, bridge(-status)-controller ^62, gas-fee-controller ^26, network-controller ^26, transaction-controller ^62.
    • Update yarn.lock entries to reflect new versions and checksums.

Written by Cursor Bugbot for commit f6b6f4c. This will update automatically on new commits. Configure here.

cfd16f1

… and transaction pay controller versions (#23029)

## **Description**

Update controller versions for `@metamask/transaction-controller` and
`@metamask/transaction-pay-controller`.

## **Changelog**

CHANGELOG entry: null

## **Related issues**

## **Manual testing steps**

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Upgrade `@metamask/transaction-controller` to `62.0.0` and
`@metamask/transaction-pay-controller` to `^9.0.0`, aligning related
dependencies and peer ranges.
> 
> - **Dependencies**:
> - Bump `@metamask/transaction-controller` from `61.3.0` to `62.0.0`
(update `resolutions` and patched reference in
`package.json`/`yarn.lock`).
> - Bump `@metamask/transaction-pay-controller` from `^7.0.0` to
`^9.0.0`.
>   - Align transitive deps/peers in `yarn.lock`:
>     - `@metamask/controller-utils` to `^11.16.0`.
> - Update peer ranges for `@metamask/accounts-controller`,
`@metamask/gas-fee-controller`, `@metamask/network-controller`, and
related bridge/assets controllers.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
1dfd594. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Nov 20, 2025
@socket-security
Copy link

socket-security bot commented Nov 20, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​controller-utils@​11.15.0 ⏵ 11.16.09910077 +196 +2100
Updatednpm/​@​metamask/​transaction-pay-controller@​7.0.0 ⏵ 9.0.0791007896 +1100
Addednpm/​@​metamask/​transaction-controller@​62.0.0981008198100

View full report

"@metamask/snaps-sdk": "^10.0.0",
"react-native@0.76.9": "patch:react-native@npm%3A0.76.9#./.yarn/patches/react-native-npm-0.76.9-1c25352097.patch",
"@metamask/transaction-controller@npm:^61.3.0": "patch:@metamask/transaction-controller@npm%3A61.3.0#~/.yarn/patches/@metamask-transaction-controller-npm-61.0.0-cccac388c7.patch"
"@metamask/transaction-controller@npm:^62.0.0": "patch:@metamask/transaction-controller@npm%3A62.0.0#~/.yarn/patches/@metamask-transaction-controller-npm-61.0.0-cccac388c7.patch"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Patch file version mismatch with upgraded package

The @metamask/transaction-controller package is upgraded from version 61.3.0 to 62.0.0, but the patch file reference still points to @metamask-transaction-controller-npm-61.0.0-cccac388c7.patch. This patch was created for version 61.0.0 and may not apply correctly to version 62.0.0, potentially causing the patch to fail silently, apply incorrectly, or miss critical changes between versions. The patch adds swapsTransactions metadata which might not be properly applied to the new version's structure.

Fix in Cursor Fix in Web

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeCore, SmokeWalletPlatform, SmokeAccounts
  • Risk Level: medium
  • AI Confidence: 45%
click to see 🤖 AI reasoning details

Only package.json (CRITICAL) and yarn.lock were modified, indicating a dependency update. Without being able to view the git diff to determine which specific dependencies were updated, I'm taking a conservative approach.

INVESTIGATION ATTEMPTS:

  • Attempted to get git diff for package.json - failed
  • Read full package.json file - too large to identify specific changes
  • Checked CHANGELOG - no recent dependency update notes
  • Unable to determine exact dependency changes

RISK FACTORS:

  1. package.json is marked CRITICAL by the system
  2. Dependency changes can have wide-ranging impacts on app functionality
  3. Unknown which dependencies changed (could be controllers, React Native, crypto libs, etc.)
  4. MetaMask Mobile has many interconnected features

SELECTED TAGS RATIONALE:

  • SmokeCore: Essential to verify core wallet functionality still works
  • SmokeWalletPlatform: Tests core wallet operations, accounts, network switching - critical infrastructure
  • SmokeAccounts: Account management is fundamental and often affected by controller updates

WHY MEDIUM RISK:

  • This is a dependency-only change (no code logic changes visible)
  • If it were a major breaking change, it would likely include code changes too
  • However, without knowing specifics, cannot rule out impactful updates

CONFIDENCE LEVEL (45%):

  • LOW confidence due to inability to see actual changes
  • Cannot determine which dependencies were updated
  • Cannot assess if updates are patch/minor/major versions
  • Cannot identify if critical packages (controllers, React Native, crypto) were affected
  • Making educated guess based on general best practices

RECOMMENDATION:
If the PR description or commit messages provide details about which dependencies were updated, that information should be used to make a more targeted decision. Consider running additional tags if the dependency changes are known to affect specific features (e.g., if swap-related packages updated, run SmokeSwaps).

View GitHub Actions results

@sonarqubecloud
Copy link

@matthewwalsh0 matthewwalsh0 merged commit 099048d into release/7.60.0 Nov 20, 2025
211 of 233 checks passed
@matthewwalsh0 matthewwalsh0 deleted the runway-cherry-pick-7.60.0-1763647316 branch November 20, 2025 22:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2025
@metamaskbot metamaskbot added the release-7.60.0 Issue or pull request that will be included in release 7.60.0 label Nov 20, 2025
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-7.60.0 on PR, as PR was cherry-picked in branch 7.60.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.60.0 Issue or pull request that will be included in release 7.60.0 size-XS team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants