-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore(runway): cherry-pick fix: cp-7.60.0 bump transaction controller and transaction pay controller versions #23041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(runway): cherry-pick fix: cp-7.60.0 bump transaction controller and transaction pay controller versions #23041
Conversation
… and transaction pay controller versions (#23029) ## **Description** Update controller versions for `@metamask/transaction-controller` and `@metamask/transaction-pay-controller`. ## **Changelog** CHANGELOG entry: null ## **Related issues** ## **Manual testing steps** ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Upgrade `@metamask/transaction-controller` to `62.0.0` and `@metamask/transaction-pay-controller` to `^9.0.0`, aligning related dependencies and peer ranges. > > - **Dependencies**: > - Bump `@metamask/transaction-controller` from `61.3.0` to `62.0.0` (update `resolutions` and patched reference in `package.json`/`yarn.lock`). > - Bump `@metamask/transaction-pay-controller` from `^7.0.0` to `^9.0.0`. > - Align transitive deps/peers in `yarn.lock`: > - `@metamask/controller-utils` to `^11.16.0`. > - Update peer ranges for `@metamask/accounts-controller`, `@metamask/gas-fee-controller`, `@metamask/network-controller`, and related bridge/assets controllers. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 1dfd594. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| "@metamask/snaps-sdk": "^10.0.0", | ||
| "react-native@0.76.9": "patch:react-native@npm%3A0.76.9#./.yarn/patches/react-native-npm-0.76.9-1c25352097.patch", | ||
| "@metamask/transaction-controller@npm:^61.3.0": "patch:@metamask/transaction-controller@npm%3A61.3.0#~/.yarn/patches/@metamask-transaction-controller-npm-61.0.0-cccac388c7.patch" | ||
| "@metamask/transaction-controller@npm:^62.0.0": "patch:@metamask/transaction-controller@npm%3A62.0.0#~/.yarn/patches/@metamask-transaction-controller-npm-61.0.0-cccac388c7.patch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Patch file version mismatch with upgraded package
The @metamask/transaction-controller package is upgraded from version 61.3.0 to 62.0.0, but the patch file reference still points to @metamask-transaction-controller-npm-61.0.0-cccac388c7.patch. This patch was created for version 61.0.0 and may not apply correctly to version 62.0.0, potentially causing the patch to fail silently, apply incorrectly, or miss critical changes between versions. The patch adds swapsTransactions metadata which might not be properly applied to the new version's structure.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsOnly package.json (CRITICAL) and yarn.lock were modified, indicating a dependency update. Without being able to view the git diff to determine which specific dependencies were updated, I'm taking a conservative approach. INVESTIGATION ATTEMPTS:
RISK FACTORS:
SELECTED TAGS RATIONALE:
WHY MEDIUM RISK:
CONFIDENCE LEVEL (45%):
RECOMMENDATION: |
|
|
No release label on PR. Adding release label release-7.60.0 on PR, as PR was cherry-picked in branch 7.60.0. |



Description
Update controller versions for
@metamask/transaction-controllerand@metamask/transaction-pay-controller.Changelog
CHANGELOG entry: null
Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Upgrade @metamask/transaction-controller (61.3.0 → 62.0.0) and @metamask/transaction-pay-controller (7.x → 9.x), updating patches and aligning peer deps; refresh yarn.lock accordingly.
@metamask/transaction-controllerto62.0.0(patched reference updated inresolutionsanddependencies).@metamask/transaction-pay-controllerto^9.0.0.@metamask/controller-utils→^11.16.0.accounts-controller^35,gas-fee-controller^26,network-controller^26.assets-controllers^90,bridge(-status)-controller^62,gas-fee-controller^26,network-controller^26,transaction-controller^62.yarn.lockentries to reflect new versions and checksums.Written by Cursor Bugbot for commit f6b6f4c. This will update automatically on new commits. Configure here.
cfd16f1