Skip to content

Conversation

@tommasini
Copy link
Contributor

@tommasini tommasini commented Nov 20, 2025

Description

timeout build android apk for e2e 40 minutes

Reference of taking only 19 minutes https://github.com/MetaMask/metamask-mobile/actions/runs/19541397562/job/55948548693

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds timeout-minutes: 40 to the build-android-apks job in .github/workflows/build-android-e2e.yml.

Written by Cursor Bugbot for commit c66917a. This will update automatically on new commits. Configure here.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Nov 20, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

This PR contains a single change to .github/workflows/build-android-e2e.yml that adds a timeout-minutes: 40 configuration to the Android APK build job.

Change Analysis:

  • The modification only adds a timeout parameter to prevent the job from running indefinitely
  • No application code changes
  • No changes to the build process, dependencies, or environment variables
  • No modifications to how APKs are built or what is included in them
  • No changes to test execution logic

Why no E2E tests are needed:

  1. Pure Infrastructure Change: This is solely a CI/CD workflow configuration that controls job execution limits
  2. No Functional Impact: The timeout setting does not affect the resulting APK artifacts, application behavior, or any features
  3. Standard CI Practice: Adding timeouts is a defensive measure to prevent hanging jobs; it's not related to application functionality
  4. Build Output Unchanged: The APKs built with or without this timeout will be functionally identical

Verification Approach:
The appropriate verification for this change is:

  • Observing that the workflow completes successfully within the timeout window
  • Confirming the job doesn't run indefinitely if issues occur
  • No E2E testing needed as no application functionality is affected

Risk Assessment:

  • Very low risk - cannot affect application behavior or user experience
  • High confidence in this assessment - the change is straightforward and isolated to CI configuration

View GitHub Actions results

@tommasini tommasini enabled auto-merge November 20, 2025 16:40
@tommasini tommasini added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Nov 20, 2025
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

We should add timeouts to to all jobs, but this is a good start

@sonarqubecloud
Copy link

@tommasini tommasini added this pull request to the merge queue Nov 20, 2025
Merged via the queue into main with commit 2b1a33a Nov 20, 2025
60 of 62 checks passed
@tommasini tommasini deleted the chore/timeout-android-build-apk-30-min branch November 20, 2025 17:18
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2025
@metamaskbot metamaskbot added the release-7.61.0 Issue or pull request that will be included in release 7.61.0 label Nov 20, 2025
@tommasini tommasini changed the title chore: timeout build android apk for e2e 30 minutes chore: timeout build android apk for e2e 40 minutes Nov 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.61.0 Issue or pull request that will be included in release 7.61.0 size-XS team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants