Skip to content

Conversation

@zone-live
Copy link
Contributor

@zone-live zone-live commented Nov 20, 2025

Description

We are updating the Tron snap to the latest version 1.9.1

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Updates @metamask/tron-wallet-snap from ^1.8.0 to ^1.9.1.

  • Dependencies:
    • Bump @metamask/tron-wallet-snap to ^1.9.1 in package.json and yarn.lock.

Written by Cursor Bugbot for commit 85018bb. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@zone-live zone-live changed the title chore: tron snap update chore: tron snap update cp-7.60.0 Nov 20, 2025
@zone-live zone-live requested a review from aganglada November 20, 2025 17:01
@socket-security
Copy link

socket-security bot commented Nov 20, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​tron-wallet-snap@​1.8.0 ⏵ 1.9.1100 +1100100 +22100 +4100

View full report

@zone-live zone-live enabled auto-merge November 20, 2025 17:04
aganglada
aganglada previously approved these changes Nov 20, 2025
@zone-live zone-live dismissed stale reviews from aganglada and ulissesferreira via 85018bb November 20, 2025 18:07
@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeNetworkExpansion, SmokeAccounts, SmokeCore
  • Risk Level: medium
  • AI Confidence: 75%
click to see 🤖 AI reasoning details

This PR updates the @metamask/tron-wallet-snap dependency from version 1.8.0 to 1.9.1. This is a minor version bump of a preinstalled snap that provides Tron blockchain support.

Risk Analysis:

  • The Tron snap is a preinstalled component similar to Solana and Bitcoin wallet snaps
  • It integrates with core wallet functionality including the snap keyring system, account management, and send/confirmation flows
  • While this is a minor version update, preinstalled snaps are critical dependencies that directly affect wallet functionality
  • The change is feature-flagged (tron), suggesting it's a distinct feature area

Test Tag Selection Rationale:

  1. SmokeNetworkExpansion (High Priority): Tron is a network expansion feature, similar to Solana and Bitcoin. This tag is specifically designed to test "New networks, network config (Solana, Bitcoin, etc)" which directly applies to Tron.

  2. SmokeAccounts (High Priority): The Tron snap integrates with the SnapKeyring system for account management. Tests under this tag cover "Multi-account, account management, BIP-44, Keyrings" which would exercise Tron account functionality.

  3. SmokeCore (Medium Priority): Preinstalled snaps are part of core wallet functionality. This ensures the snap initialization, loading, and basic integration with Engine and core controllers work correctly.

Why Not Other Tags:

  • SmokeConfirmationsRedesigned: While Tron has send confirmation hooks, the snap update itself is unlikely to break general confirmation flows without affecting network or account functionality first
  • Other tags: Not directly related to network expansion or snap functionality

Confidence: 75% - The change is clear (dependency version bump), and the impact area is well-defined (Tron network support). However, without specific Tron E2E tests in the codebase and limited visibility into what changed between snap versions 1.8.0 and 1.9.1, there's some uncertainty about the full scope of testing needed.

View GitHub Actions results

@sonarqubecloud
Copy link

@zone-live zone-live added this pull request to the merge queue Nov 20, 2025
Merged via the queue into main with commit 935e555 Nov 20, 2025
193 of 217 checks passed
@zone-live zone-live deleted the NWNT-tron-snap-version-bump branch November 20, 2025 21:22
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2025
@metamaskbot metamaskbot added the release-7.61.0 Issue or pull request that will be included in release 7.61.0 label Nov 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.61.0 Issue or pull request that will be included in release 7.61.0 size-XS team-new-networks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants