-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix(predict): cp-7.60.0 fade in gtm modal after image loads #23080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
app/components/UI/Predict/components/PredictGTMModal/PredictGTMModal.tsx
Show resolved
Hide resolved
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsThe changes are isolated to the PredictGTMModal component, which is a Go-To-Market modal for the Predictions feature. The modifications add a fade-in animation using react-native-reanimated when the background image loads (500ms duration transition from opacity 0 to 1). While the changes are primarily cosmetic/presentational, they affect a user-facing component in the Predictions onboarding flow. The animation could potentially introduce visual issues or timing problems that should be validated through E2E testing. The SmokePredictions tag is the most appropriate choice because:
Risk is assessed as medium (not low) because:
No other tags are necessary as the changes are completely isolated to the Predictions feature area. |
|
kevinbluer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice approach 👍


Description
Currently the GTM modal for Predict looks funky as it seems to render different pieces at different times.
This PR attempts to fix this by introducing two main changes:
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
RPReplay_Final1763676703.MP4
After
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-11-20.at.15.53.07.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds a reanimated opacity fade-in for the Predict GTM modal that starts once the background image finishes loading.
Animated.Viewand animatesopacityfrom 0→1 withwithTiming.onLoadviauseState+useEffectanduseSharedValue/useAnimatedStyle.Written by Cursor Bugbot for commit ae4bba0. This will update automatically on new commits. Configure here.