fix(perps): calculate weighted ROE percentage for aggregated account states cp-7.60.0

[michalconsensys]

Description

This PR fixes the calculation of return on equity (ROE) percentage for aggregated account states across multiple DEX accounts in the Perps feature. Previously, the ROE was calculated using a simple formula that didn't account for the different margin amounts across accounts, which could lead to inaccurate percentage values.

Changelog

CHANGELOG entry: Fixed return on equity percentage calculation for aggregated Perps positions across multiple DEX accounts

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/TAT-2086

Manual testing steps

Feature: Perps aggregated account ROE calculation

  Scenario: user views aggregated account state with multiple DEX positions
    Given user has multiple Perps positions across different DEX accounts with varying margin amounts
    And each position has different unrealized PnL and ROE values
    
    When user views the aggregated account state
    Then the displayed ROE percentage should be a weighted average based on margin used
    And the calculation should correctly handle accounts with zero or negative values
    And invalid or NaN values should be skipped in the calculation

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Replaces aggregate ROE with a margin-weighted calculation and adds comprehensive unit tests.

• Perps utils:
  • Weighted ROE: Add calculateWeightedReturnOnEquity (and ReturnOnEquityInput) in app/components/UI/Perps/utils/accountUtils.ts to compute margin-weighted ROE across accounts.
  • Integrate weighted ROE in HyperLiquidSubscriptionService.aggregateAccountStates() by using calculateWeightedReturnOnEquity instead of the previous simple ratio.
• Tests:
  • Add extensive unit tests in app/components/UI/Perps/utils/accountUtils.test.ts covering mixed types, edge cases (zero/negative/NaN), precision, and multi-account scenarios.

^{Written by Cursor Bugbot for commit 334fcd6. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeAccounts, SmokeCore, SmokeConfirmationsRedesigned, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeWalletUX, SmokeAssets, SmokeSwaps, SmokeStake, SmokeCard, SmokeNotifications, SmokeRewards, SmokePerps, SmokeRamps, SmokeMultiChainPermissions, SmokeAnalytics, SmokeMultiChainAPI, SmokePredictions
• Risk Level: high
• AI Confidence: %

click to see 🤖 AI reasoning details

Fallback: AI analysis did not complete successfully. Running all tests.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
3 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud