Skip to content

Conversation

@runway-github
Copy link
Contributor

@runway-github runway-github bot commented Nov 26, 2025

Description

Fix Non-EVM accounts not found
Fixes part of this
MetaMask/metamask-extension#38104

Changelog

CHANGELOG entry: fix: non-evm accounts not found

Related issues

Fixes: MetaMask/metamask-extension#38104

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Upgrade snaps dependencies in package.json: @metamask/solana-wallet-snap to ^2.5.0 and @metamask/tron-wallet-snap to ^1.13.0 (with lockfile updates).

Written by Cursor Bugbot for commit b108def. This will update automatically on new commits. Configure here.

ec74886

…23318)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Fix Non-EVM accounts not found 
Fixes part of this
MetaMask/metamask-extension#38104

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: fix: non-evm accounts not found

## **Related issues**

Fixes: MetaMask/metamask-extension#38104

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Updates Solana and Tron wallet snap dependencies to newer minor
versions.
> 
> - **Dependencies**:
> - Bump `@metamask/solana-wallet-snap` from `^2.4.7` to `^2.5.0` in
`package.json`.
> - Bump `@metamask/tron-wallet-snap` from `^1.12.1` to `^1.13.0` in
`package.json`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
628c91e. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Nov 26, 2025
@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeCore, SmokeAccounts, SmokeAssets, SmokeSwaps, SmokeConfirmationsRedesigned, SmokeWalletPlatform
  • Risk Level: high
  • AI Confidence: 45%
click to see 🤖 AI reasoning details

The changes are to package.json and yarn.lock, which are critical dependency management files. Without access to the git diff, I cannot determine the exact nature or scope of the dependency changes.

Key considerations:

  1. Critical Files: package.json is pre-marked as critical, and dependency changes can have cascading effects throughout the application
  2. Unknown Scope: Unable to see which specific dependencies changed, their version bumps, or if new dependencies were added
  3. Potential Impact Areas: Dependency changes could affect:
    • Core wallet functionality (controllers, Engine)
    • Asset management and display
    • Network abstractions and connections
    • UI components and user flows
    • Transaction handling and confirmations
    • Account management

Risk Assessment:

  • High Risk: Because these are dependency files in a financial application where bugs could lead to loss of funds or security issues
  • Conservative Approach: Running core smoke tests to ensure critical paths remain functional after dependency updates

Selected Tags Rationale:

  • SmokeCore: Core wallet functionality must be verified
  • SmokeAccounts: Account management could be affected by controller or crypto library updates
  • SmokeAssets: Asset display and management relies on various dependencies
  • SmokeSwaps: Swap functionality involves multiple dependencies
  • SmokeConfirmationsRedesigned: Transaction confirmations are critical and could be affected
  • SmokeWalletPlatform: Core wallet and platform operations

Confidence Level: 45/100 (Low-Medium)

  • Cannot see actual changes in the diff
  • Unknown which dependencies were modified
  • Conservative approach warranted given the criticality of the application
  • Would prefer to see the specific dependency changes to make a more informed decision

View GitHub Actions results

@socket-security
Copy link

socket-security bot commented Nov 26, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​tron-wallet-snap@​1.12.1 ⏵ 1.13.01001007998 +1100
Updatednpm/​@​metamask/​solana-wallet-snap@​2.4.7 ⏵ 2.5.097 -31008898 +1100

View full report

@sonarqubecloud
Copy link

@joaoloureirop joaoloureirop merged commit 2fb3ccb into release/7.60.0 Nov 26, 2025
11 checks passed
@joaoloureirop joaoloureirop deleted the runway-cherry-pick-7.60.0-1764174570 branch November 26, 2025 20:10
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2025
@metamaskbot metamaskbot added the release-7.60.0 Issue or pull request that will be included in release 7.60.0 label Nov 26, 2025
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-7.60.0 on PR, as PR was cherry-picked in branch 7.60.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.60.0 Issue or pull request that will be included in release 7.60.0 team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants