-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: enable require-pr-numbers flag for changelog generation #23661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Update @metamask/auto-changelog from ^5.1.0 to ^5.3.0 - Update update-release-changelog workflow to use github-tools v1.1.2 This aligns metamask-mobile with metamask-extension for changelog generation, ensuring only commits with PR numbers are included.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsThe changes in this PR are limited to:
None of these changes:
While package.json is flagged as CRITICAL, in this specific case the change is purely a dev tooling update with zero impact on application behavior. No E2E tests are necessary to validate these changes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Caution MetaMask internal reviewing guidelines:
|
|



Description
This PR updates the changelog workflows to use the new
@metamask/auto-changelog@5.3.0which always filters out direct commits without PR numbers. This ensures all changelog entries represent reviewed and approved changes.Changes:
@metamask/auto-changelogfrom^5.1.0to^5.3.0update-release-changelogworkflow to usegithub-tools@v1.1.2The
--requirePrNumbersflag is now always applied by default in github-tools, so no additional configuration is needed.This aligns
metamask-mobilewithmetamask-extensionfor consistent changelog generation across platforms.Changelog
CHANGELOG entry: null
Related issues
Manual testing steps
Tested on consensys-test/metamask-extension-test with
release/1100.0.0:Screenshots/Recordings
Before
Direct commits without PR numbers would appear in the changelog.
After
Only commits with PR numbers (representing reviewed changes) appear in the changelog.
Pre-merge author checklist
Pre-merge reviewer checklist