Bugfix/sync improvements #2417
Merged
Bugfix/sync improvements #2417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
force-pushed
the
bugfix/sync-improvements
branch
from
fad78a5 to
e6854fd
Compare
rickycodes
force-pushed
the
bugfix/sync-improvements
branch
from
7ecd9fa to
ac8ef1f
Compare
rickycodes
added
needs-dev-review
This reverts commit 25ea4ba.
rickycodes
removed
the
needs-dev-review
ibrahimtaveras00
added
QA Passed
estebanmino
pushed a commit
that referenced
this pull request
Mar 22, 2021
* Add missing onErrorSync call * Add loadingMsg * Simplify * Remove unused SyncWithExtension view * Update snapshots * Add loadingMsg initial state * always fail sync * Revert "always fail sync" This reverts commit 25ea4ba.
estebanmino
pushed a commit
that referenced
this pull request
Mar 24, 2021
* Add missing onErrorSync call * Add loadingMsg * Simplify * Remove unused SyncWithExtension view * Update snapshots * Add loadingMsg initial state * always fail sync * Revert "always fail sync" This reverts commit 25ea4ba.
rickycodes
added a commit
that referenced
this pull request
Jan 31, 2022
* Add missing onErrorSync call * Add loadingMsg * Simplify * Remove unused SyncWithExtension view * Update snapshots * Add loadingMsg initial state * always fail sync * Revert "always fail sync" This reverts commit 25ea4ba.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a couple of a small bugs. The main one is that when syncing with the extension there was a case where if
JSON.parsefailed you'd end up in a catch, but we never sent the user back so they'd get stuck in a loading state. This also simplifies some of the loading logic and ensures we display the correct message when syncing (there were instances where if you had deleted the wallet and then went back to sync you'd see the delete messaging instead). Lastly I removed theSyncWithExtensionview since we're actually not using that any more.Checklist
Issue
Resolves #https://github.com/MetaMask/mobile-planning/issues/83