Only get nonce from the network if the feature is enabled #2543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
added
the
needs-dev-review
ShevaSHIO
reviewed
Apr 18, 2021
andrepimenta
approved these changes
Apr 19, 2021
rickycodes
added a commit
to ScreamingHawk/metamask-mobile
that referenced
this pull request
Apr 30, 2021
…tch-1 * 'develop' of github.com:MetaMask/metamask-mobile: (51 commits) Feature/confusables (MetaMask#2464) fix typeface on login text field (MetaMask#2610) Replace controller context (MetaMask#2416) Fix adding custom token in custom network (MetaMask#2590) only add custom tokens if not in mainnet (MetaMask#2470) Address yarn lints (MetaMask#2524) Upgrade .nvmrc to node v14 (MetaMask#2588) Swaps: Add cache thresholds configuration (MetaMask#2514) Swaps: BSC Support (MetaMask#2468) Use node 14 (MetaMask#2539) resolve isENS without case sensitivity (MetaMask#2545) (MetaMask#2568) Revert "resolve isENS without case sensitivity (MetaMask#2545)" (MetaMask#2566) resolve isENS without case sensitivity (MetaMask#2545) Bump versioncode (MetaMask#2558) v2.2.0 (MetaMask#2555) Include decimalsToShow in balanceToFiatNumber (MetaMask#2547) Bug fix/sync import time (MetaMask#2554) bundle update (MetaMask#2549) Fix analytics try catch (MetaMask#2546) Only get nonce from the network if the feature is enabled (MetaMask#2543) ...
rickycodes
added a commit
that referenced
this pull request
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looking more closely at the custom nonce work that was recently completed I realized we were getting the network nonce and then... not doing anything with it (even for users that have the feature disabled). this change ensures we only get the nonce from the network if the user has the
showCustomNoncefeature enabled.