Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ignoreSilentSwitch and reset the video onEnd #2697

Merged
merged 3 commits into from
May 18, 2021

Conversation

rickycodes
Copy link
Contributor

Description

This will allow audio regardless of the status of the silent switch on iOS devices. This will also reset the video to be played again once it's finished playing (feedback from @wachunei).

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@rickycodes rickycodes requested a review from a team as a code owner May 18, 2021 16:36
@rickycodes rickycodes force-pushed the feature/ignore-silent-switch branch from 7928865 to 4b26f74 Compare May 18, 2021 16:37
Copy link
Member

@wachunei wachunei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickycodes rickycodes merged commit 2e50f9b into develop May 18, 2021
@rickycodes rickycodes deleted the feature/ignore-silent-switch branch May 18, 2021 17:49
rickycodes added a commit that referenced this pull request Jan 31, 2022
* Set ignoreSilentSwitch and reset the video onEnd

* Add useCallback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants