Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Improve transaction state management for custom networks #3155

Merged
merged 21 commits into from
Sep 23, 2021
Merged

[FEAT] Improve transaction state management for custom networks #3155

merged 21 commits into from
Sep 23, 2021

Conversation

gantunesr
Copy link
Member

Controller's PR: MetaMask/core#598

@gantunesr gantunesr added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Sep 21, 2021
@gantunesr gantunesr requested a review from a team as a code owner September 21, 2021 13:06
Cal-L
Cal-L approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are minimal on mobile. LGTM.
cc: @gantunesr

@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Sep 22, 2021
@cortisiko cortisiko self-assigned this Sep 22, 2021
cortisiko
cortisiko approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 🌮 🌮

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Sep 23, 2021
@cortisiko cortisiko assigned gantunesr and unassigned cortisiko Sep 23, 2021
@mobularay mobularay removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 23, 2021
@gantunesr gantunesr merged commit 886b021 into develop Sep 23, 2021
@gantunesr gantunesr deleted the feat/tx-state-custom-chains branch September 23, 2021 21:06
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
[FEAT] Improve transaction state management for custom networks (#3155)
8f51961
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortisiko cortisiko cortisiko approved these changes

@Cal-L Cal-L Cal-L approved these changes

Assignees

@gantunesr gantunesr

Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gantunesr @Cal-L @cortisiko @mobularay