Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Android APK Size, App Load Time, Bitrise Build Steps #3423

Merged
merged 14 commits into from
Nov 23, 2021
Merged

[IMPROVEMENT] Android APK Size, App Load Time, Bitrise Build Steps #3423

merged 14 commits into from
Nov 23, 2021
+36 −10

Conversation

sethkfman
Copy link
Contributor

Description

  • Enabled pro guard to reduced APK release size
  • Enabled Hermes for release load times
  • Created new Bitrise specific to store release

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #3390

@sethkfman sethkfman requested a review from a team as a code owner November 16, 2021 19:59
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman changed the title Improvement/android build updates [IMPROVEMENT] Android APK Size, App Load Time, Bitrise Build Steps Nov 16, 2021
rickycodes
rickycodes reviewed Nov 18, 2021
View reviewed changes
Copy link
Contributor

@rickycodes rickycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrepimenta andrepimenta added the No QA Needed Apply this label when your PR does not need any QA effort. label Nov 23, 2021
@sethkfman sethkfman merged commit c5268df into develop Nov 23, 2021
@sethkfman sethkfman deleted the improvement/android-build-updates branch November 23, 2021 16:57
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rickycodes rickycodes rickycodes left review comments

@andrepimenta andrepimenta andrepimenta approved these changes

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance: Android Metrics and Crash Review
3 participants
@sethkfman @rickycodes @andrepimenta