Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Android Keyboard Text Entry #3459

Merged
merged 6 commits into from
Dec 2, 2021
Merged

[FIX] Android Keyboard Text Entry #3459

merged 6 commits into from
Dec 2, 2021
+100 −43

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Nov 30, 2021 •
edited
Loading

Description

Added a check for users using gboard as a keyboard and removing keyboard learning during the use of the MetaMask app.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issues

Related #3460

@sethkfman sethkfman requested a review from a team as a code owner November 30, 2021 16:48
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 30, 2021
@sethkfman sethkfman linked an issue Nov 30, 2021 that may be closed by this pull request
Android Keyboard Issues #3460
Closed
@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 30, 2021
cortisiko
cortisiko approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay so I tested:

  • browser keyboard interactions, deleting a wallet, searching for tokens, adding a token, adding an NFT, requesting a token, searching for a token(s) in the swaps flow & Entering your password in the secure your wallet flow.

  • enabled gboard then repeated the first bullet point

  • enabled swiftKey Keyboard then repeated the first bullet point

  • disabled gboard and enabled samsung keyboard and repeated the first bullet point

with that being said, 🌮 🌮🌮🌮🌮🌮

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Nov 30, 2021
@sethkfman sethkfman self-assigned this Dec 1, 2021
@sethkfman sethkfman mentioned this pull request Dec 1, 2021
Closed
Cal-L
Cal-L requested changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request to remove extra RN patch changes. LGTM after that's addressed

@sethkfman sethkfman requested a review from Cal-L December 1, 2021 23:12
@sethkfman
Copy link
Contributor Author

@Cal-L Updated RN patch.

Cal-L
Cal-L approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman merged commit f5a1d65 into develop Dec 2, 2021
@sethkfman sethkfman deleted the fix/enable-privacy-gboard branch December 2, 2021 22:46
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

@Cal-L Cal-L Cal-L approved these changes

Assignees

@sethkfman sethkfman

Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Android Keyboard Issues
3 participants
@sethkfman @Cal-L @cortisiko