-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear the clipboard after the seed phrase is pasted #3461
Merged
Merged
+21
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
force-pushed
the
feature/clear-clipboard-after-srp-paste
branch
from
November 30, 2021 18:57
dd893f8
to
9431e16
Compare
sethkfman
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rickycodes
force-pushed
the
feature/clear-clipboard-after-srp-paste
branch
from
November 30, 2021 19:58
d2365ea
to
ec86950
Compare
rickycodes
force-pushed
the
feature/clear-clipboard-after-srp-paste
branch
from
January 6, 2022 16:43
78af644
to
cd87de3
Compare
rickycodes
force-pushed
the
feature/clear-clipboard-after-srp-paste
branch
from
February 1, 2022 20:56
cd87de3
to
390fe59
Compare
rickycodes
added
the
needs-qa
Any New Features that needs a full manual QA prior to being added to a release.
label
Feb 1, 2022
cortisiko
added
QA in Progress
QA has started on the feature.
and removed
needs-qa
Any New Features that needs a full manual QA prior to being added to a release.
labels
Feb 3, 2022
cortisiko
approved these changes
Feb 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌮 🌮 🌮
cortisiko
added
QA Passed
A successful QA run through has been done
and removed
QA in Progress
QA has started on the feature.
labels
Feb 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to MetaMask/metamask-extension#12828
On the "Import" page of the import flow, we now clear the clipboard after the secret recovery phrase is pasted. This ensures that the SRP isn't accidentally pasted somewhere else by the user, which can be an easy and disastrous mistake to make.