Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear the clipboard after the seed phrase is pasted #3461

Merged
merged 7 commits into from
Feb 3, 2022

Conversation

rickycodes
Copy link
Contributor

Description

Similar to MetaMask/metamask-extension#12828

On the "Import" page of the import flow, we now clear the clipboard after the secret recovery phrase is pasted. This ensures that the SRP isn't accidentally pasted somewhere else by the user, which can be an easy and disastrous mistake to make.

@rickycodes rickycodes requested a review from a team as a code owner November 30, 2021 18:36
@rickycodes rickycodes force-pushed the feature/clear-clipboard-after-srp-paste branch from dd893f8 to 9431e16 Compare November 30, 2021 18:57
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickycodes rickycodes force-pushed the feature/clear-clipboard-after-srp-paste branch from d2365ea to ec86950 Compare November 30, 2021 19:58
@rickycodes rickycodes force-pushed the feature/clear-clipboard-after-srp-paste branch from 78af644 to cd87de3 Compare January 6, 2022 16:43
@rickycodes rickycodes changed the base branch from develop to main January 26, 2022 18:43
@rickycodes rickycodes force-pushed the feature/clear-clipboard-after-srp-paste branch from cd87de3 to 390fe59 Compare February 1, 2022 20:56
@rickycodes rickycodes added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Feb 1, 2022
@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Feb 3, 2022
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Feb 3, 2022
@rickycodes rickycodes merged commit cd517ce into main Feb 3, 2022
@rickycodes rickycodes deleted the feature/clear-clipboard-after-srp-paste branch February 3, 2022 20:32
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants