-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Avoid canceling transactions after submission #4060
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…cancelled, rejected or confirmed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test case 1:
|
Any progress on this? If this issue is resolved i can continue with my Dapp :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ticket is QA passed. Scenarios I tested:
Send transaction
Swap transaction
dapps transactions.
I no longer see the ooops something went wrong
alert message when the app was in the background. I also did not see that alert message when I killed and relaunched the app. Finally with push notifications turned on I did not receive a ooops something went wrong
notification. Good work @tommasini 🌮 🌮
Description
When we put the app in the background we were trying to cancel the transaction. The transaction still succeeded because the transaction status it's not cancelable but shows one notification that says "Oops Something went wrong".
Proposed solution
The proposed solution is only to cancel the transaction if the status it's not, submitted, cancellable, approved, failed and rejected when the app goes to the background.
Code Impact
The code impact is low, since we just change the code when the app state (foreground, background), changes.
Screenshots/Videos
Bug:
https://recordit.co/Pqa7Uq34hv
Solution:
https://recordit.co/EkE0jdyCMj
Test Cases
Case1:
Case 2:
Case 3:
Checklist
Issue
Progresses ##3927