Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.4][FIX] Swaps approval transaction #4263

Merged
merged 19 commits into from
Jul 8, 2022
Merged

[5.4][FIX] Swaps approval transaction #4263

merged 19 commits into from
Jul 8, 2022

Conversation

gantunesr
Copy link
Member

Description

Detailed in issue #262.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Progresses #262.

@gantunesr gantunesr added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels May 10, 2022
@gantunesr gantunesr requested a review from a team as a code owner May 10, 2022 00:59
@gantunesr gantunesr mentioned this pull request May 10, 2022
Closed
3 tasks
sethkfman
sethkfman approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plasmacorral plasmacorral self-assigned this May 11, 2022
@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 12, 2022
@plasmacorral plasmacorral added QA in Progress QA has started on the feature. and removed QA in Progress QA has started on the feature. labels Jun 8, 2022
@gantunesr gantunesr changed the title [FIX] Swaps approval transaction [5.4][FIX] Swaps approval transaction Jun 9, 2022
@cortisiko cortisiko added the release-5.4.0 Issue or pull request that will be included in release 5.4.0 label Jun 16, 2022
@plasmacorral plasmacorral added QA in Progress QA has started on the feature. needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. QA in Progress QA has started on the feature. labels Jun 16, 2022
@plasmacorral plasmacorral added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jun 16, 2022
@plasmacorral
Copy link
Contributor

plasmacorral commented Jun 16, 2022 •
edited
Loading

Testing commit hash ebb3c58 I am seeing that a leading zero is now required in the approval modal. This was on both iOS 15 and Android 12 devices.

prod: https://recordit.co/4qpREQ892D
pr: https://recordit.co/uRypMsj402

Are we able to support a user entering ".xxxxxxx" (minus the leading zero) without undermining the fixes included?

@plasmacorral plasmacorral added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed QA in Progress QA has started on the feature. labels Jun 16, 2022
@gantunesr
Copy link
Member Author

gantunesr commented Jul 5, 2022 •
edited
Loading

@plasmacorral I think its better to leave it as it is since the app is validating with a Regex expression (it does undermine the fixes)

@gantunesr gantunesr added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Jul 5, 2022
@mobularay mobularay added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 5, 2022
@plasmacorral plasmacorral added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Jul 8, 2022
@gantunesr gantunesr merged commit 3b6268b into main Jul 8, 2022
@gantunesr gantunesr deleted the fix/approval-txs branch July 8, 2022 03:26
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees

@plasmacorral plasmacorral

Labels
QA Passed A successful QA run through has been done release-5.4.0 Issue or pull request that will be included in release 5.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gantunesr @plasmacorral @sethkfman @cortisiko @mobularay