[FEAT] Swaps support for hardware wallet #4475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gantunesr
added
needs-qa
|
The new flow looks good. |
wachunei
removed
the
needs-dev-review
gantunesr
added
release-5.5.0
plasmacorral
added
QA in Progress
|
Have an observation from feature QA, but confirmed to be in production. Will open a separate issue. |
plasmacorral
added
QA Passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation of swaps doesn't integrate well with transactions that requires to be signed in hardware wallet, this PR aims to adjust the logic to make integrations easier. But this is not the ideal solution, a refactor is necessary to improve the UX/UI for this use case, for that reason I decided to make the minimal modifications necessaries.
Checklist
Screenshots/Recordings
If applicable, add screenshots or recordings to visualize the changes
Issue
Progresses https://github.com/MetaMask/mobile-planning/issues/274
Progresses https://github.com/MetaMask/mobile-planning/issues/1029