Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component/4085 tab bar item #4548

Merged
merged 14 commits into from
Jun 28, 2022
Merged

Component/4085 tab bar item #4548

merged 14 commits into from
Jun 28, 2022

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Jun 21, 2022

Description

#4085

How it looks in storybook
image

With knobs
image

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Screenshots/Recordings

If applicable, add screenshots or recordings to visualize the changes

Issue

Progresses #???

@Cal-L Cal-L requested a review from a team as a code owner June 21, 2022 06:28
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L changed the base branch from main to component/4221-icon June 21, 2022 18:00
@Cal-L Cal-L added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 23, 2022
Base automatically changed from component/4221-icon to main June 23, 2022 16:24
@jpcloureiro jpcloureiro removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 28, 2022
@Cal-L Cal-L merged commit 7f32237 into main Jun 28, 2022
@Cal-L Cal-L deleted the component/4085-tab-bar-item branch June 28, 2022 23:34
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2022
@Cal-L Cal-L added the release-5.4.0 Issue or pull request that will be included in release 5.4.0 label Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-5.4.0 Issue or pull request that will be included in release 5.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants