-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NFT transfer with big token id #4636
Fix NFT transfer with big token id #4636
Conversation
JavaScript's parseInt does not handle big number
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I have read the CLA Document and I hereby sign the CLA |
Thanks for the contribution @wdv4758h, do you mind adding unit tests cases to the |
Thanks @wdv4758h. The PR LGTM, I'll move forward for our QA team to test it. They'll point out in this PR any issues they find. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@wdv4758h I see a linting error in the code, can you fix it please
You can use |
@gantunesr done, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested on polygon, BSC and main net: swaps, sending ERC-721's, Sending ENS ERC-721's, sending ERC-20's and native currencies
this is 🌮 🌮 🌮 🌮
Description
Current implementation does not work with big token id. This will cause NFT transfer failure, since the id will be converted to something not correct.
For example:
This PR simply change the conversion to use BigNumber, which is already in the codebase.
Screenshots/Recordings
Issue
Hex string conversion failure cause NFT transfer failure.
Checklist