Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add log for vault corruption #4655

Merged
merged 6 commits into from
Jul 26, 2022
Merged

Add log for vault corruption #4655

merged 6 commits into from
Jul 26, 2022

Conversation

gantunesr
Copy link
Member

No description provided.

@gantunesr gantunesr added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jul 12, 2022
@gantunesr gantunesr requested a review from a team as a code owner July 12, 2022 12:45
@gantunesr gantunesr added the release-5.4.0 Issue or pull request that will be included in release 5.4.0 label Jul 12, 2022
@owencraston
Copy link
Contributor

This is going to be so helpful!

@gantunesr gantunesr requested a review from owencraston July 12, 2022 15:26
@sethkfman sethkfman added release-5.5.0 Issue or pull request that will be included in release 5.5.0 and removed release-5.4.0 Issue or pull request that will be included in release 5.4.0 labels Jul 12, 2022
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@owencraston owencraston force-pushed the log/vault-corruption branch from 3db25ef to bdbf8d6 Compare July 21, 2022 16:45
owencraston
owencraston reviewed Jul 21, 2022
View reviewed changes
bitrise.yml Outdated Show resolved Hide resolved
@owencraston
Copy link
Contributor

I followed the same pattern as the the authentication type user property from this PR

@owencraston owencraston force-pushed the log/vault-corruption branch from bdbf8d6 to 7e3f5cf Compare July 21, 2022 19:08
sethkfman
sethkfman approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andrepimenta
andrepimenta approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@andrepimenta andrepimenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sethkfman sethkfman removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 26, 2022
@owencraston owencraston force-pushed the log/vault-corruption branch from 78804f0 to 8b807f9 Compare July 26, 2022 20:38
sethkfman
sethkfman approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owencraston owencraston mentioned this pull request Jul 26, 2022
Open
@owencraston
Copy link
Contributor

after trying to set the user properties in this PR I opted to revert the changes and made a separate issue to track this work

@owencraston owencraston force-pushed the log/vault-corruption branch from bc29141 to 40236d8 Compare July 26, 2022 21:46
@owencraston owencraston merged commit e3e2802 into main Jul 26, 2022
@owencraston owencraston deleted the log/vault-corruption branch July 26, 2022 21:59
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@owencraston owencraston owencraston left review comments

@sethkfman sethkfman sethkfman approved these changes

@andrepimenta andrepimenta andrepimenta approved these changes

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-5.5.0 Issue or pull request that will be included in release 5.5.0 team-accounts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gantunesr @owencraston @andrepimenta @sethkfman