-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Screenshot Warning #4670
Merged
Merged
+1,048
−889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feat/screenshot-alert
…to feat/screenshot-alert
…to feat/screenshot-alert
gantunesr
added
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
team-accounts
labels
Jul 13, 2022
3 tasks
gantunesr
added
the
release-5.13.0
Issue or pull request that will be included in release 5.13.0
label
Nov 29, 2022
olenapankina
added
QA in Progress
QA has started on the feature.
and removed
needs-qa
Any New Features that needs a full manual QA prior to being added to a release.
labels
Dec 15, 2022
olenapankina
added
QA'd - Issues Found
QA has been complete, however issues have been discovered that need to be addressed
and removed
QA in Progress
QA has started on the feature.
labels
Dec 20, 2022
gantunesr
added
needs-qa
Any New Features that needs a full manual QA prior to being added to a release.
and removed
QA'd - Issues Found
QA has been complete, however issues have been discovered that need to be addressed
labels
Dec 20, 2022
olenapankina
added
QA in Progress
QA has started on the feature.
and removed
needs-qa
Any New Features that needs a full manual QA prior to being added to a release.
labels
Dec 21, 2022
cortisiko
approved these changes
Dec 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is 🌮 🌮 .
Scenarios covered outside of the AC mentioned here:
- A user attempts to take a screenshot while his language is not set to English. Ensuring that the text in the warning alert defaults to English
- Regression on android. Nothing is broken there.
cortisiko
added
QA Passed
A successful QA run through has been done
and removed
QA in Progress
QA has started on the feature.
labels
Dec 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
QA Passed
A successful QA run through has been done
release-5.13.0
Issue or pull request that will be included in release 5.13.0
team-accounts
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
Improve the security around SRP reveal.
2. What is the improvement/solution?
iOS specific. This PR adds a warning when the user takes a screenshot of their SRP or Private Key.
Changes:
Introduction ofreact-native-detector
v0.2.1 packageRevealPrivateCredential
and move styles to a different fileManualBackupStep1
and move styles to a different fileit also refactors the component
RevealPrivateCredential
andManualBackupStep1
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
RPReplay_Final1657683451.MP4
Note: You can observe a similar behaviour in the onboarding flow.
Issue
Progresses https://github.com/MetaMask/mobile-planning/issues/227
Checklist