Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component/4233 account picker #4689

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Component/4233 account picker #4689

merged 2 commits into from
Jul 19, 2022

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Jul 19, 2022

Description

#4233

PickerItem (Wrapper)
image

PickerAccount (Uses PickerItem under the hood)
image

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L marked this pull request as ready for review July 19, 2022 02:25
@Cal-L Cal-L requested a review from a team as a code owner July 19, 2022 02:25
@Cal-L Cal-L added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 19, 2022
jpcloureiro
jpcloureiro approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@jpcloureiro jpcloureiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Cal-L Cal-L merged commit efb8b98 into main Jul 19, 2022
@Cal-L Cal-L deleted the component/4233-account-picker branch July 19, 2022 19:28
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpcloureiro jpcloureiro jpcloureiro approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cal-L @jpcloureiro