Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user agent from Webview property as default in HTTP interceptor (Android) #4830

Merged
merged 4 commits into from
Aug 11, 2022
Merged

Add user agent from Webview property as default in HTTP interceptor (Android) #4830

merged 4 commits into from
Aug 11, 2022

Conversation

Fatxx
Copy link
Contributor

@Fatxx Fatxx commented Aug 10, 2022 •
edited
Loading

Description

The userAgent property provided in the Webview component on Android isn't being properly set in the interceptor, now it should use the provided property value and fallback to the device user agent when this property is not defined.

Screenshots/Recordings

With userAgent property defined in WebView:

Screen Shot 2022-08-10 at 10 46 30

Without userAgent property in WebView:

Screen Shot 2022-08-10 at 10 49 10

Related slack thread:
https://consensys.slack.com/archives/CBW7S9FSN/p1659995161910989

Issue

Progresses #4829

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@Fatxx Fatxx added the android Android specific issue label Aug 10, 2022
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Fatxx Fatxx marked this pull request as ready for review August 10, 2022 09:57
@Fatxx Fatxx requested a review from a team as a code owner August 10, 2022 09:57
@Fatxx Fatxx added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. release-5.7.0 Issue or pull request that will be included in release 5.7.0 labels Aug 10, 2022
@wachunei
Copy link
Member

This is working as expected for the on-ramp requirements 👍

andreahaku
andreahaku approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@andreahaku andreahaku left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM even if I don't understand the reason for the renaming of the 'm*' variables into 'RN*' :)

@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Aug 11, 2022
cortisiko
cortisiko approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression on the browser as well as the other web views (view block explorer, submit a feature, support, and all the links on the about view) in the app are functionally sound.

🌮 🌮 🌮

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Aug 11, 2022
@cortisiko cortisiko merged commit 6d54e2c into main Aug 11, 2022
@cortisiko cortisiko deleted the fix/user-agent-android-webview branch August 11, 2022 22:46
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

@andreahaku andreahaku andreahaku approved these changes

Assignees
No one assigned
Labels
android Android specific issue QA Passed A successful QA run through has been done release-5.7.0 Issue or pull request that will be included in release 5.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fatxx @wachunei @andreahaku @cortisiko