Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] ENS Wildcard and offchain resolution #5002

Merged
merged 4 commits into from
Sep 21, 2022
Merged

[FEAT] ENS Wildcard and offchain resolution #5002

merged 4 commits into from
Sep 21, 2022

Conversation

gantunesr
Copy link
Member

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
(This was originally a community PR.)

Support for MetaMask/specifications#9

2. What is the improvement/solution?
Add new ENS provider for Wildcard resolutions and introduce the package @ethersproject/shims to address RN network limitations.

For more information about @ethersproject/shims use the following resources,

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr marked this pull request as ready for review September 20, 2022 23:14
@gantunesr gantunesr requested a review from a team as a code owner September 20, 2022 23:14
@cortisiko cortisiko added the Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking label Sep 20, 2022
cortisiko
cortisiko approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮

@cortisiko cortisiko added the release-5.8.0 Issue or pull request that will be included in release 5.8.0 label Sep 21, 2022
@cortisiko cortisiko merged commit 6d838e5 into main Sep 21, 2022
@cortisiko cortisiko deleted the feat/ens-wildcard-offchain-resolution branch September 21, 2022 01:05
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

Assignees
No one assigned
Labels
release-5.8.0 Issue or pull request that will be included in release 5.8.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gantunesr @cortisiko