Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-Ramp: Provider payment method custom action and custom order ids #5158

Merged
merged 34 commits into from
Nov 1, 2022

Conversation

wachunei
Copy link
Member

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PRs includes the custom action for provider's payment method and the use of custom order ids.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei added the team-ramp issues related to Ramp features label Oct 27, 2022
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@wachunei wachunei added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Oct 27, 2022
@wachunei wachunei marked this pull request as ready for review October 31, 2022 11:56
@wachunei wachunei requested a review from a team as a code owner October 31, 2022 11:56
@wachunei wachunei added the release-5.10.0 Issue or pull request that will be included in release 5.10.0 label Oct 31, 2022
bitrise.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

@sethkfman sethkfman removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 1, 2022
@wachunei wachunei removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Nov 1, 2022
@socket-security
Copy link

socket-security bot commented Nov 1, 2022

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Non-existent author ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

Ignoring: fsevents@1.2.13, react-native@0.56.0, react-native@0.56.1, react-native@0.57.8, wordwrap@0.0.2

Powered by socket.dev

@wachunei
Copy link
Member Author

wachunei commented Nov 1, 2022

@SocketSecurity ignore fsevents@1.2.13 react-native@0.56.0 react-native@0.56.1 react-native@0.57.8 wordwrap@0.0.2

@wachunei wachunei merged commit 586b297 into main Nov 1, 2022
@wachunei wachunei deleted the feature/onramp-provider-custom-action branch November 1, 2022 23:29
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-5.10.0 Issue or pull request that will be included in release 5.10.0 team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants