Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Fixes and configuration updates related to Branch.io Deep Links #5262

Merged
merged 5 commits into from
Nov 23, 2022
Merged

[BUGFIX] Fixes and configuration updates related to Branch.io Deep Links #5262

merged 5 commits into from
Nov 23, 2022

Conversation

andreahaku
Copy link
Contributor

@andreahaku andreahaku commented Nov 17, 2022 •
edited
Loading

  • react-native-branch updated to latest version (5.6.2)
  • info.plist configuration updated
  • updates Android MainActivity to singleTask from singleInstance

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Those changes are meant to make deep links more reliable and stable on Android and iOS.

The issue with Android 12+ not automatically verifying our deep links domains has been fixed and should no longer require the user to manually "enable" them. This is made on the Branch.io backend side but requires the user to re-install/update the app.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@andreahaku andreahaku changed the title Fixes and configuration updates related to Branch.io Deep Links [BUGFIX] Fixes and configuration updates related to Branch.io Deep Links Nov 18, 2022
@andreahaku andreahaku added release-5.12.0 Issue or pull request that will be included in release 5.12.0 needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Nov 21, 2022
@andreahaku andreahaku marked this pull request as ready for review November 21, 2022 14:50
@andreahaku andreahaku requested a review from a team as a code owner November 21, 2022 14:50
@andreahaku andreahaku self-assigned this Nov 21, 2022
tommasini
tommasini approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Cal-L
Cal-L approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreahaku andreahaku added needs-qa Any New Features that needs a full manual QA prior to being added to a release. regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead Priority - High Task with high priority and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 22, 2022
@andreahaku andreahaku merged commit e90a90c into main Nov 23, 2022
@andreahaku andreahaku deleted the bugfix/branchio_deeplinks branch November 23, 2022 16:51
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2022
@chrisleewilcox chrisleewilcox removed the regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead label May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

@Cal-L Cal-L Cal-L approved these changes

Assignees

@andreahaku andreahaku

Labels
Priority - High Task with high priority release-5.12.0 Issue or pull request that will be included in release 5.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreahaku @Cal-L @tommasini @chrisleewilcox