Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On-ramp: fix default payment method selection #5292

Merged
merged 2 commits into from
Nov 24, 2022
Merged

On-ramp: fix default payment method selection #5292

merged 2 commits into from
Nov 24, 2022

Conversation

wachunei
Copy link
Member

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR fixes a bug introduced by the new filter of customAction, the bug consisted in a wrongly selected default payment method.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei requested a review from a team as a code owner November 24, 2022 16:14
@wachunei wachunei added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features release-5.12.0 Issue or pull request that will be included in release 5.12.0 labels Nov 24, 2022
rickycodes
rickycodes approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@rickycodes rickycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one question, but lgtm regardless

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 24, 2022
andreahaku
andreahaku approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 24, 2022
@wachunei wachunei merged commit 8c7c6e2 into main Nov 24, 2022
@wachunei wachunei deleted the fix/onramp-default-payment-method branch November 24, 2022 20:00
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreahaku andreahaku andreahaku approved these changes

@rickycodes rickycodes rickycodes approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-5.12.0 Issue or pull request that will be included in release 5.12.0 team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wachunei @rickycodes @andreahaku