Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Remove RPC URL metrics #5307

Merged
merged 3 commits into from
Dec 1, 2022
Merged

[IMPROVEMENT] Remove RPC URL metrics #5307

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c98223f
Remove RPC URL from "Network Switched" event
gantunesr Nov 28, 2022
f37817d
Remove RPC URL from "Network Added" event
gantunesr Nov 28, 2022
c2928eb
Remove block_explorer_url parameter
gantunesr Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/components/UI/NetworkList/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,6 @@ export class NetworkList extends PureComponent {
NetworkController.setRpcTarget(rpcUrl, chainId, ticker, nickname);

AnalyticsV2.trackEvent(AnalyticsV2.ANALYTICS_EVENTS.NETWORK_SWITCHED, {
rpc_url: rpcUrl,
chain_id: chainId,
source: 'Settings',
symbol: ticker,
gantunesr marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
3 changes: 0 additions & 3 deletions app/components/UI/NetworkModal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import InfoModal from '../Swaps/components/InfoModal';
import ImageIcons from '../../UI/ImageIcon';
import { useDispatch } from 'react-redux';
import AnalyticsV2 from '../../../util/analyticsV2';
import sanitizeUrl from '../../../util/sanitizeUrl';
import { useTheme } from '../../../util/theme';
import { networkSwitched } from '../../../actions/onboardNetwork';
import generateTestId from '../../../../wdio/utils/generateTestId';
Expand Down Expand Up @@ -154,7 +153,6 @@ const NetworkModals = (props: NetworkProps) => {

if (validUrl) {
const url = new URLPARSE(rpcUrl);
const sanitizedUrl = sanitizeUrl(url.href);
const decimalChainId = getDecimalChainId(chainId);
!isprivateConnection(url.hostname) && url.set('protocol', 'https:');
PreferencesController.addToFrequentRpcList(
Expand All @@ -168,7 +166,6 @@ const NetworkModals = (props: NetworkProps) => {
);

const analyticsParamsAdd = {
rpc_url: sanitizedUrl,
chain_id: decimalChainId,
source: 'Popular network list',
symbol: ticker,
gantunesr marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
1 change: 0 additions & 1 deletion app/components/Views/Settings/NetworksSettings/NetworkSettings/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,6 @@ class NetworkSettings extends PureComponent {
);

const analyticsParamsAdd = {
rpc_url: formattedHref,
chain_id: decimalChainId,
source: 'Custom network form',
symbol: ticker,
gantunesr marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
2 changes: 0 additions & 2 deletions app/core/RPCMethods/wallet_addEthereumChain.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ const wallet_addEthereumChain = async ({
}

const analyticsParams = {
rpc_url: existingNetwork?.rpcUrl,
chain_id: _chainId,
source: 'Custom Network API',
symbol: existingNetwork?.ticker,
gantunesr marked this conversation as resolved.
Show resolved Hide resolved
Expand Down Expand Up @@ -263,7 +262,6 @@ const wallet_addEthereumChain = async ({
requestData.alert = alert;

const analyticsParamsAdd = {
rpc_url: firstValidRPCUrl,
chain_id: chainIdDecimal,
source: 'Custom Network API',
symbol: ticker,
Expand Down
1 change: 0 additions & 1 deletion app/core/RPCMethods/wallet_switchEthereumChain.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ const wallet_switchEthereumChain = async ({
};
analyticsParams = {
...analyticsParams,
rpc_url: existingNetworkRPC?.rpcUrl,
symbol: existingNetworkRPC?.ticker,
block_explorer_url: existingNetworkRPC?.blockExplorerUrl,
gantunesr marked this conversation as resolved.
Show resolved Hide resolved
network_name: 'rpc',
Expand Down