Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not track rpc_url in metrics #5308

Closed
wants to merge 2 commits into from
Closed

do not track rpc_url in metrics #5308

wants to merge 2 commits into from

Conversation

brad-decker
Copy link
Contributor

Description
Removes rpc_url and block_explorer_url from event payloads to protect privacy.
Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue
Fixes #5302

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr
Copy link
Member

Hey @brad-decker, we already have a PR (#5307) to improve this.

@gantunesr gantunesr closed this Nov 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure private RPC and Chain explorer URLs are not sent to sent to MetaMetrics
2 participants